Fix remote SSH tunnelling bug

Fix crash when no auth callback
Fixed auth callback crash and config file reading
2008-01-17 15:21:08 +00:00 · 2008-01-14 04:08:08 +00:00 · 2008-01-02 21:47:05 +00:00 · 2007-12-18 11:02:18 +00:00 · 2007-10-21 00:04:39 +00:00
4 changed files with 26 additions and 4 deletions
@@ -22,4 +22,3 @@ libvirt-0.3.0.tar.gz
 libvirt-0.3.1.tar.gz
 libvirt-0.3.2.tar.gz
 libvirt-0.3.3.tar.gz
-libvirt-0.4.0.tar.gz
@@ -0,0 +1 @@
+F-8
@@ -0,0 +1,17 @@
+diff -rup libvirt-0.4.0.orig/src/remote_internal.c libvirt-0.4.0.new/src/remote_internal.c
+--- libvirt-0.4.0.orig/src/remote_internal.c	2008-01-14 19:32:25.000000000 -0500
+++ libvirt-0.4.0.new/src/remote_internal.c	2008-01-14 19:32:42.000000000 -0500
+@@ -677,11 +677,12 @@ doRemoteOpen (virConnectPtr conn,
+         cmd_argv[j++] = strdup (sockname ? sockname : LIBVIRTD_PRIV_UNIX_SOCKET);
+         cmd_argv[j++] = 0;
+         assert (j == nr_args);
+-        for (j = 0; j < nr_args; j++)
+        for (j = 0; j < (nr_args-1); j++) {
+             if (cmd_argv[j] == NULL) {
+                 error (conn, VIR_ERR_SYSTEM_ERROR, strerror (ENOMEM));
+                 goto failed;
+             }
+        }
+     }
+ 
+         /*FALLTHROUGH*/
@@ -11,13 +11,14 @@
 Summary: Library providing a simple API virtualization
 Name: libvirt
 Version: 0.4.0
-Release: 3%{?dist}%{?extra_release}
+Release: 4%{?dist}%{?extra_release}
 License: LGPL
 Group: Development/Libraries
 Source: libvirt-%{version}.tar.gz
 Patch1: libvirt-%{version}-auth-null-cb.patch
 Patch2: libvirt-%{version}-conffile-size.patch
 Patch3: libvirt-%{version}-auth-null-cb-2.patch
+Patch4: libvirt-%{version}-remote-ssh.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-root
 URL: http://libvirt.org/
 BuildRequires: python python-devel
@@ -93,6 +94,7 @@ of recent versions of Linux (and other OSes).
 %patch1 -p1
 %patch2 -p1
 %patch3 -p1
+%patch4 -p1

 %build
 # Xen is availble only on i386 x86_64 ia64
@@ -218,10 +220,13 @@ fi
 %doc docs/examples/python

 %changelog
-* Sun Jan 13 2008 Daniel P. Berrange <berrange@redhat.com> - 0.4.0-3.fc9
+* Thu Jan 17 2008 Daniel P. Berrange <berrange@redhat.com> - 0.4.0-4.fc8
+- Fix SSH tunnelling (rhbz #428743)
+
+* Sun Jan 13 2008 Daniel P. Berrange <berrange@redhat.com> - 0.4.0-3.fc8
 - Fix crash when no auth callback

-* Wed Jan  2 2008 Daniel P. Berrange <berrange@redhat.com> - 0.4.0-2.fc9
+* Wed Jan  2 2008 Daniel P. Berrange <berrange@redhat.com> - 0.4.0-2.fc8
 - Fix reading large config files (rhbz #426425)
 - Fix crash when connecting to a PolicyKit enabled server with not auth callback (rhbz #427107)
Author	SHA1	Message	Date
Daniel P. Berrange	5238691972	Fix remote SSH tunnelling bug	2008-01-17 15:21:08 +00:00
Daniel P. Berrange	49bd0fe0f6	Fix crash when no auth callback	2008-01-14 04:08:08 +00:00
Daniel P. Berrange	f57c13f43b	Fixed auth callback crash and config file reading	2008-01-02 21:47:05 +00:00
Daniel Veillard	b4531a6202	Update to 0.4.0, remove old patches not needed anymore, Daniel	2007-12-18 11:02:18 +00:00
Jesse Keating	0685aa3535	Initialize branch F-8 for libvirt	2007-10-21 00:04:39 +00:00