btrfs: abort transaction if we fail to update inode in log replay dir fixup
[ Upstream commit 5a0565cad3ef7cbf4cf43d1dd1e849b156205292 ] If we fail to update the inode at link_to_fixup_dir(), we don't abort the transaction and propagate the error up the call chain, which makes it hard to pinpoint the error to the inode update. So abort the transaction if the inode update call fails, so that if it happens we known immediately. Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
2f4097e63e
commit
3bc6f92c66
@@ -1796,6 +1796,8 @@ static noinline int link_to_fixup_dir(struct btrfs_trans_handle *trans,
|
||||
else
|
||||
inc_nlink(vfs_inode);
|
||||
ret = btrfs_update_inode(trans, inode);
|
||||
if (ret)
|
||||
btrfs_abort_transaction(trans, ret);
|
||||
} else if (ret == -EEXIST) {
|
||||
ret = 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user