Commit Graph
26 Commits
Author SHA1 Message Date
Anil Belur 29dd4f9be6 staging: lustre: ptlrpc: lproc_ptlrpc.c - fix dereferenceing user space buffer
- this fixes sparse warning for directly deferencing user space buffer

drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33:    expected void const [noderef] <asn:1>*from
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33:    got char const *buffer

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:42:51 -07:00
Anil Belur f1555465d3 staging: lustre: ldlm: ldlm_resource.c - fix dereferenceing user space buffer
- this fixes sparse warning for directly deferencing user space buffer

./lustre/ldlm/ldlm_resource.c:202:35: warning: incorrect type in argument 2 (different address spaces)
./lustre/ldlm/ldlm_resource.c:202:35:    expected void const [noderef] <asn:1>*from
./lustre/ldlm/ldlm_resource.c:202:35:    got char const *buffer

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:40:30 -07:00
Anil Belur a0f7fe5b14 [media] staging: media: bcm2048: radio-bcm2048.c - removed IRQF_DISABLED macro
- this patch removes IRQF_DISABLED macro, as this is
  deprecated/noop.

Signed-off-by: Anil Belur <askb23@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
2014-07-17 20:05:03 -03:00
Anil Belur dd3fde11d3 staging: speakup: speakup_dectlk.c - use time_before_eq()
- this replaces jiffies comparision with safer function using
  time_after_eq()

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:52:33 -07:00
Anil Belur 51bd88146f staging: lustre: lnet: api-ni.c: fixed sparse warnings
- this fixes few sparse warnings for missing static in functions:

drivers/staging/lustre/lnet/lnet/api-ni.c:63:6: warning: symbol 'lnet_get_routes' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:69:6: warning: symbol 'lnet_get_networks' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:93:1: warning: symbol 'lnet_init_locks' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:102:1: warning: symbol 'lnet_fini_locks' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:180:6: warning: symbol 'lnet_assert_wire_constants' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:273:7: warning: symbol 'lnet_find_lnd_by_type' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:419:1: warning: symbol 'lnet_create_interface_cookie' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:450:1: warning: symbol 'lnet_res_container_cleanup' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:494:1: warning: symbol 'lnet_res_container_setup' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:612:1: warning: symbol 'lnet_prepare' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:917:1: warning: symbol 'lnet_shutdown_lndnis' was not declared. Should it be static?
drivers/staging/lustre/lnet/lnet/api-ni.c:1034:1: warning: symbol 'lnet_startup_lndnis' was not declared. Should it be static?

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:31:40 -07:00
Anil Belur b0126abf72 staging: lustre: llite: dir.c - fix for coding style issues
- this fixes some coding style issues "ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:54:59 -04:00
Anil Belur eb73f514de staging: lustre: llite: dir.c - fixes indented labels in code
- this fixes "WARNING: labels should not be indented"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:54:59 -04:00
Anil Belur 576eb39a6b staging: lustre: llite: llite_capa.c - fixed warning to use recomended headers <linux/uaccess.h>
- this fixes "WARNING: Use #include <linux/uaccess.h> instead of
  <asm/uaccess.h>"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:54:58 -04:00
Anil Belur 8bcf3c2381 staging: lustre: llite: llite_capa.c - fixes checkpatch errors - unecessary init of static variables to 0
- this commit fixes some "ERROR: do not initialise statics to 0 or NULL"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:54:58 -04:00
Anil Belur 0d2f6bb4b2 staging: lustre: lustre: libcfs: fail.c - fix sparse warnings EXPORT_SYMBOL
- this fixes "WARNING: EXPORT_SYMBOL(foo); should immediately follow its
  function/variable"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:54:58 -04:00
Anil Belur 05dca37303 staging: lustre: ldlm: ldlm_lib.c removed unecessary space after function name
- this fixes "WARNING: space prohibited between function name and open
  parenthesis '("

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:23:53 -07:00
Anil Belur b7cfd6d468 staging: lustre: lustre: ldlm: ldlm_lib.c - removed unnecessary braces
- this change fixes "WARNING: braces {} are not necessary for single
  statement blocks"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:23:53 -07:00
Anil Belur 13d6b73eae staging: lustre: lustre: fld: lproc_fld.c fixed warning
fixed warning "WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:23:09 -07:00
Anil Belur 48f46e74dc staging: lustre: lustre: fld: lproc_fld.c fixed warning
fixed warning for line over 80 characters by moving the struct init
onto a diff line.

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:23:09 -07:00
Anil Belur ae59720b3a staging: lustre: ldlm: ldlm_resource.c replace obsolete function with kstrtoul()
- this change fixes the warning "WARNING: simple_strtoul is obsolete, use
kstrtoul instead"
- removed the unused var 'end' as this is no longer required for
  kstrtoul()

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:22:24 -07:00
Anil Belur bf050e55a3 staging: lustre: ldlm: ldlm_resource.c removed unecessary braces
- this fixed the "WARNING: braces {} are not necessary for
  single statement blocks"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:22:24 -07:00
Anil Belur d1acbe57c7 staging : lustre : lustre : fid : lproc_fid.c: fixed warning
fixed warning for line over 80 characters by moving the initilation
onto a diff line.

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19 17:22:24 -07:00
Anil Belur 98e1137005 staging: lustre: lclient: lcommon_cl.c fixing coding style issues
fixed: WARNING: suspect code indent for conditional statements (32, 32)

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:40:17 -07:00
Anil Belur 81851d4646 staging: lustre: lclient: lcommon_cl.c fixing coding style issues
fixed: WARNING: line over 80 characters, used a new variable 'size_index' to
store the offset. Replaced "unsigned long" with  "loff_t" type for
'cur_index'. Removed the parenthesis around the second part of the if statement following the '||' as its not required.

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:40:17 -07:00
Anil Belur 60dc39b4d8 staging: lustre: lclient: lcommon_cl.c fixing coding style issues
fixed: ERROR: inline keyword should sit between storage class and type

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:40:17 -07:00
Anil Belur 847d47faa3 staging: lustre: lclient: lcommon_cl.c fixing coding style issues
fixed:  ERROR: do not initialise statics to 0 or NULL

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:39:19 -07:00
Anil Belur 772f34f582 staging: lustre: lclient: lcommon_cl.c fixing coding style issues
fixed: WARNING: Missing a blank line after declarations

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:39:19 -07:00
Anil Belur 2df2b3a8be staging: lustre: lclient: lcommon_misc.c fixing coding style issues
fixed warning:
* WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count,
LOV_MAX_STRIPE_COUNT)

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:39:18 -07:00
Anil Belur 641cff7773 staging: lustre: lclient: glimpse.c fixing coding style issues
fixed "WARNING: labels should not be indented"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:37:13 -07:00
Anil Belur df47bd43f7 staging: lustre: lclient: glimpse.c fixing coding style issues
Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)"

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-18 15:37:13 -07:00
Anil Belur ae35f26644 staging: ozwpan: ozproto.c fix for "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)"
Fixed the warning message by replacing memcpy() with ether_addr_copy()

Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23 21:10:50 +09:00