cifs: Add comments for DeletePending assignments in open functions
On more places is set DeletePending member to 0. Add comments why is 0 the correct value. Paths in DELETE_PENDING state cannot be opened by new calls. So if the newly issued open for that path succeed then it means that the path cannot be in DELETE_PENDING state. Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
@@ -1163,7 +1163,7 @@ OldOpenRetry:
|
||||
cpu_to_le64(le32_to_cpu(pSMBr->EndOfFile));
|
||||
pfile_info->EndOfFile = pfile_info->AllocationSize;
|
||||
pfile_info->NumberOfLinks = cpu_to_le32(1);
|
||||
pfile_info->DeletePending = 0;
|
||||
pfile_info->DeletePending = 0; /* successful open = not delete pending */
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1288,7 +1288,7 @@ openRetry:
|
||||
buf->AllocationSize = rsp->AllocationSize;
|
||||
buf->EndOfFile = rsp->EndOfFile;
|
||||
buf->NumberOfLinks = cpu_to_le32(1);
|
||||
buf->DeletePending = 0;
|
||||
buf->DeletePending = 0; /* successful open = not delete pending */
|
||||
}
|
||||
|
||||
cifs_buf_release(req);
|
||||
|
||||
@@ -676,7 +676,7 @@ finished:
|
||||
idata->fi.EndOfFile = create_rsp->EndofFile;
|
||||
if (le32_to_cpu(idata->fi.NumberOfLinks) == 0)
|
||||
idata->fi.NumberOfLinks = cpu_to_le32(1); /* dummy value */
|
||||
idata->fi.DeletePending = 0;
|
||||
idata->fi.DeletePending = 0; /* successful open = not delete pending */
|
||||
idata->fi.Directory = !!(le32_to_cpu(create_rsp->FileAttributes) & ATTR_DIRECTORY);
|
||||
|
||||
/* smb2_parse_contexts() fills idata->fi.IndexNumber */
|
||||
|
||||
@@ -3277,7 +3277,7 @@ replay_again:
|
||||
buf->EndOfFile = rsp->EndofFile;
|
||||
buf->Attributes = rsp->FileAttributes;
|
||||
buf->NumberOfLinks = cpu_to_le32(1);
|
||||
buf->DeletePending = 0;
|
||||
buf->DeletePending = 0; /* successful open = not delete pending */
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user