dlan17/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

io-wq: remove spurious bit clear on task_work addition

Browse Source 
There's a small race here where the task_work could finish and drop
the worker itself, so that by the time that task_work_add() returns
with a successful addition we've already put the worker.

The worker callbacks clear this bit themselves, so we don't actually
need to manually clear it in the caller. Get rid of it.

Reported-by: syzbot+b60c982cb0efc5e05a47@syzkaller.appspotmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Jens Axboe
2021-12-06 10:49:04 -07:00
parent a226abcd5d
commit e47498afec
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/io-wq.c
+1 -3
View File
@@ -359,10 +359,8 @@ static bool io_queue_worker_create(struct io_worker *worker,
init_task_work(&worker->create_work, func);
worker->create_index = acct->index;
if (!task_work_add(wq->task, &worker->create_work, TWA_SIGNAL)) {
clear_bit_unlock(0, &worker->create_state);
if (!task_work_add(wq->task, &worker->create_work, TWA_SIGNAL))
return true;
}
clear_bit_unlock(0, &worker->create_state);
fail_release:
io_worker_release(worker);