dlan17/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

smb: client: remove redudant assignment in cifs_strict_fsync()

Browse Source 
Remove redudant assignment of @rc as it will be overwritten by the
following cifs_file_flush() call.

Reported-by: Steve French <stfrench@microsoft.com>
Addresses-Coverity: 1665925
Fixes: 210627b0aca9 ("smb: client: fix missing timestamp updates with O_TRUNC")
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Cc: linux-cifs@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Paulo Alcantara
2025-10-09 11:16:25 -05:00
committed by Steve French
parent dba9f997c9
commit be3898a395
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/smb/client/file.c
+4 -9
View File
@@ -2754,7 +2754,7 @@ int cifs_strict_fsync(struct file *file, loff_t start, loff_t end,
struct cifsFileInfo *smbfile = file->private_data;
struct inode *inode = file_inode(file);
unsigned int xid;
int rc = 0;
int rc;
rc = file_write_and_wait_range(file, start, end);
if (rc) {
@@ -2762,19 +2762,14 @@ int cifs_strict_fsync(struct file *file, loff_t start, loff_t end,
return rc;
}
xid = get_xid();
cifs_dbg(FYI, "Sync file - name: %pD datasync: 0x%x\n",
file, datasync);
cifs_dbg(FYI, "%s: name=%pD datasync=0x%x\n", __func__, file, datasync);
if (!CIFS_CACHE_READ(CIFS_I(inode))) {
rc = cifs_zap_mapping(inode);
if (rc) {
cifs_dbg(FYI, "rc: %d during invalidate phase\n", rc);
rc = 0; /* don't care about it in fsync */
}
cifs_dbg(FYI, "%s: invalidate mapping: rc = %d\n", __func__, rc);
}
xid = get_xid();
rc = cifs_file_flush(xid, inode, smbfile);
free_xid(xid);
return rc;