dlan17/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kconfig: qconf: use preferred form of QString API

Browse Source 
A QString constructed from a character literal of length 0, i.e. "", is not
"null" for historical reasons. This does not matter here so use the preferred
method isEmpty() instead.

Also directly construct empty QString objects instead of passing in an empty
character literal that has to be parsed into an empty object first.

Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Link: https://doc.qt.io/qt-6/qstring.html#distinction-between-null-and-empty-strings
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Rolf Eike Beer
2025-01-10 23:01:22 +09:00
committed by Masahiro Yamada
parent 41a0005128
commit ad2091dee0
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/kconfig/qconf.cc
+4 -4
View File
@@ -1464,8 +1464,8 @@ void ConfigMainWindow::loadConfig(void)
{
QString str;
str = QFileDialog::getOpenFileName(this, "", configname);
if (str.isNull())
str = QFileDialog::getOpenFileName(this, QString(), configname);
if (str.isEmpty())
return;
if (conf_read(str.toLocal8Bit().constData()))
@@ -1491,8 +1491,8 @@ void ConfigMainWindow::saveConfigAs(void)
{
QString str;
str = QFileDialog::getSaveFileName(this, "", configname);
if (str.isNull())
str = QFileDialog::getSaveFileName(this, QString(), configname);
if (str.isEmpty())
return;
if (conf_write(str.toLocal8Bit().constData())) {