dlan17/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kconfig: gconf: remove unneeded variables in on_treeview*_button_press_event()

Browse Source 
Not all position parameters are used here. Passing NULL to
gtk_tree_view_get_cursor() or gtk_tree_view_get_path_at_pos() is
allowed. [1] [2]

[1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/gtk/gtktreeview.c#L12638
[1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/gtk/gtktreeview.c#L12795

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada
2025-07-01 20:07:35 +09:00
parent 8e3136eb27
commit 57b63d17f7
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/kconfig/gconf.c
+3 -11
View File
@@ -822,13 +822,10 @@ on_treeview2_button_press_event(GtkWidget * widget,
GtkTreeIter iter;
struct menu *menu;
gint col;
gint tx = (gint) event->x;
gint ty = (gint) event->y;
gint cx, cy;
gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, &cx,
&cy);
gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, NULL, NULL);
if (path == NULL)
return FALSE;
@@ -871,12 +868,11 @@ on_treeview2_key_press_event(GtkWidget * widget,
{
GtkTreeView *view = GTK_TREE_VIEW(widget);
GtkTreePath *path;
GtkTreeViewColumn *column;
GtkTreeIter iter;
struct menu *menu;
gint col;
gtk_tree_view_get_cursor(view, &path, &column);
gtk_tree_view_get_cursor(view, &path, NULL);
if (path == NULL)
return FALSE;
@@ -930,16 +926,12 @@ on_treeview1_button_press_event(GtkWidget * widget,
{
GtkTreeView *view = GTK_TREE_VIEW(widget);
GtkTreePath *path;
GtkTreeViewColumn *column;
GtkTreeIter iter;
struct menu *menu;
gint tx = (gint) event->x;
gint ty = (gint) event->y;
gint cx, cy;
gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, &cx,
&cy);
gtk_tree_view_get_path_at_pos(view, tx, ty, &path, NULL, NULL, NULL);
if (path == NULL)
return FALSE;