dlan17/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: libsas: Refactor dev_is_sata()

Browse Source 
Use a switch statement in dev_is_sata() to make the code more readable
(and probably slightly better than a series of or conditions). Also have
this inline function return a boolean instead of an integer.

No functional changes.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250725015818.171252-2-dlemoal@kernel.org
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Damien Le Moal
2025-07-25 09:03:56 -04:00
committed by Martin K. Petersen
parent 19272b37aa
commit 54091eee08
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/scsi/sas_ata.h
+12 -5
View File
@@ -15,10 +15,17 @@
#ifdef CONFIG_SCSI_SAS_ATA
static inline int dev_is_sata(struct domain_device *dev)
static inline bool dev_is_sata(struct domain_device *dev)
{
return dev->dev_type == SAS_SATA_DEV || dev->dev_type == SAS_SATA_PM ||
dev->dev_type == SAS_SATA_PM_PORT || dev->dev_type == SAS_SATA_PENDING;
switch (dev->dev_type) {
case SAS_SATA_DEV:
case SAS_SATA_PENDING:
case SAS_SATA_PM:
case SAS_SATA_PM_PORT:
return true;
default:
return false;
}
}
int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy);
@@ -49,9 +56,9 @@ static inline void sas_ata_disabled_notice(void)
pr_notice_once("ATA device seen but CONFIG_SCSI_SAS_ATA=N\n");
}
static inline int dev_is_sata(struct domain_device *dev)
static inline bool dev_is_sata(struct domain_device *dev)
{
return 0;
return false;
}
static inline int sas_ata_init(struct domain_device *dev)
{