dlan17/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

security: remove redundant assignment to return variable

Browse Source 
In the case where rc is equal to EOPNOTSUPP it is being reassigned a
new value of zero that is never read. The following continue statement
loops back to the next iteration of the lsm_for_each_hook loop and
rc is being re-assigned a new value from the call to getselfattr.
The assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Serge Hallyn <serge@hallyn.com>
[PM: subj tweak]
Signed-off-by: Paul Moore <paul@paul-moore.com>
This commit is contained in:
Colin Ian King
2025-01-04 21:52:13 -05:00
committed by Paul Moore
parent 7ccbe076d9
commit 241d6a6640
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
security/security.c
+1 -3
View File
@@ -4138,10 +4138,8 @@ int security_getselfattr(unsigned int attr, struct lsm_ctx __user *uctx,
if (base)
uctx = (struct lsm_ctx __user *)(base + total);
rc = scall->hl->hook.getselfattr(attr, uctx, &entrysize, flags);
if (rc == -EOPNOTSUPP) {
rc = 0;
if (rc == -EOPNOTSUPP)
continue;
}
if (rc == -E2BIG) {
rc = 0;
left = 0;