bpf: bpftool: Setting error code in do_loader()

We are missing setting error code in do_loader() when
bpf_object__open_file() fails. This means the command's exit status code
will be successful, even though the operation failed. So make sure to
return the correct error code. To maintain consistency with other
locations where bpf_object__open_file() is called, return -1.

  [0] Closes: https://github.com/libbpf/bpftool/issues/156

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Sewon Nam <swnam0729@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Tested-by: Quentin Monnet <qmo@kernel.org>
Reviewed-by: Quentin Monnet <qmo@kernel.org>
Link: https://lore.kernel.org/bpf/d3b5b4b4-19bb-4619-b4dd-86c958c4a367@stanley.mountain/t/#u
Link: https://lore.kernel.org/bpf/20250311031238.14865-1-swnam0729@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

This commit is contained in:

Sewon Nam

2025-03-15 11:48:58 -07:00

committed by

Alexei Starovoitov

parent a9041fbd90

commit 02a4694107

1 changed files with 1 additions and 0 deletions

									
										tools/bpf/bpftool/prog.c
									
		+1
		
												View File
												
				@@ -1928,6 +1928,7 @@ static int do_loader(int argc, char **argv)

					obj = bpf_object__open_file(file, &open_opts);

					if (!obj) {

						err = -1;

						p_err("failed to open object file");

						goto err_close_obj;

					}