mirror of
https://github.com/clearlinux/systemd-stable.git
synced 2026-10-03 23:38:39 +00:00
bootchart: remove duplicated code, prevent creating empty files
In Debian and rawhide Fedora, which have CONFIG_SCHEDSTATS=n, bootchart creates empty files in /run/log before printing an error. Stop doing that. Moreover this duplicated part of the code doesn't even have error checking so there is no error avoided by doing this early. Reported-by: tfirg_ on IRC
This commit is contained in:
committed by
Zbigniew Jędrzejewski-Szmek
parent
fb02a2775a
commit
b53a2485a4
@@ -395,15 +395,6 @@ int main(int argc, char *argv[]) {
|
||||
sampledata->sampletime = gettime_ns();
|
||||
sampledata->counter = samples;
|
||||
|
||||
if (!of && (access(arg_output_path, R_OK|W_OK|X_OK) == 0)) {
|
||||
t = time(NULL);
|
||||
r = strftime(datestr, sizeof(datestr), "%Y%m%d-%H%M", localtime(&t));
|
||||
assert_se(r > 0);
|
||||
|
||||
snprintf(output_file, PATH_MAX, "%s/bootchart-%s.svg", arg_output_path, datestr);
|
||||
of = fopen(output_file, "we");
|
||||
}
|
||||
|
||||
if (sysfd < 0)
|
||||
sysfd = open("/sys", O_RDONLY|O_CLOEXEC);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user