clearlinux/systemd-stable
2
0
Fork 0
mirror of https://github.com/clearlinux/systemd-stable.git synced 2026-09-06 05:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

sd-network: avoid false positive compiler warning caused by LTO

Browse Source 
Djalal Harouni <tixxdz@opendz.org>:
There is also this one genrated by LTO, IMO it's a false positive since
we do *check* for "lease" but the code is not consistent since in that
code path, "lease" is initialized to NULL in other places, except for
this one:

src/resolve/resolved-manager.c: In function 'manager_update_resolv_conf':
src/libsystemd-network/sd-dhcp-lease.c:67:18: warning: 'lease' may be used uninitialized in this function [-Wmaybe-uninitialized]
        if (lease->dns_size) {
                 ^
src/network/sd-network.c:146:24: note: 'lease' was declared here
        sd_dhcp_lease *lease;
                       ^
This commit is contained in:
Tom Gundersen
2014-05-24 00:46:30 +02:00
parent 640ace4a8d
commit 68baa8faf3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/sd-network.c
+1 -1
View File
@@ -143,7 +143,7 @@ _public_ int sd_network_get_link_operational_state(unsigned index, char **state)
_public_ int sd_network_get_dhcp_lease(unsigned index, sd_dhcp_lease **ret) {
_cleanup_free_ char *p = NULL, *s = NULL;
sd_dhcp_lease *lease;
sd_dhcp_lease *lease = NULL;
int r;
assert_return(index, -EINVAL);