clearlinux/systemd-stable
2
0
Fork 0
mirror of https://github.com/clearlinux/systemd-stable.git synced 2026-10-04 15:58:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

bus: unref buscreds on failure

Browse Source 
Actually unref the buscreds when we are not going to return a
pointer to them. As when bus_creds_add_more fails we immediately
return the error code otherwise and leak the new buscreds.
Found with coverity. Fixes: CID#1237761
This commit is contained in:
Philippe De Swert
2014-09-11 17:29:19 +02:00
committed by David Herrmann
parent b67ddc7bbe
commit 2b347169b9
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libsystemd/sd-bus/sd-bus.c
+3 -1
View File
@@ -3339,8 +3339,10 @@ _public_ int sd_bus_get_peer_creds(sd_bus *bus, uint64_t mask, sd_bus_creds **re
}
r = bus_creds_add_more(c, mask, pid, 0);
if (r < 0)
if (r < 0) {
sd_bus_creds_unref(c);
return r;
}
*ret = c;
return 0;