clearlinux/swupd-client
2
0
Fork 0
mirror of https://github.com/clearlinux/swupd-client.git synced 2026-10-04 15:58:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

config_loader: Don't check for sizes before using strcmp()

Browse Source 
Checking for a string size as expensive than comparing it with another string
(maybe slightly faster because we're comparing with zeroes), but on average
it will be more expensive because we need to check the full string.
I wouldn't check for size unless we have any noticeable performance problems.

Signed-off-by: Otavio Pontes <otavio.pontes@intel.com>
This commit is contained in:
Otavio Pontes
2019-07-17 14:16:56 -07:00
committed by Castulo J. Martinez
parent 4e19e331e4
commit ca0a8b2a11
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/config_loader.c
+1 -5
View File
@@ -47,8 +47,6 @@ bool config_loader_set_opt(char *section, char *opt, char *value)
char *lvalue = NULL;
char *lsection = NULL;
char *flag = NULL;
size_t opt_len;
size_t flag_len;
bool ret = false;
/* make sure the config loader has been initialized */
@@ -60,7 +58,6 @@ bool config_loader_set_opt(char *section, char *opt, char *value)
/* replace all '_' used in config options with '-' used in flags */
flag = strdup_or_die(opt);
flag_len = strlen(flag);
for (unsigned int i = 0; flag[i]; i++) {
if (flag[i] == '_') {
flag[i] = '-';
@@ -80,8 +77,7 @@ bool config_loader_set_opt(char *section, char *opt, char *value)
/* search the option from within the available options */
while (options->name != NULL) {
opt_len = strlen(options->name);
if (flag_len == opt_len && strcmp(flag, options->name) == 0) {
if (strcmp(flag, options->name) == 0) {
lvalue = str_tolower(value);
/* some options don't have short options, only long, if this is the