clearlinux/swupd-client
2
0
Fork 0
mirror of https://github.com/clearlinux/swupd-client.git synced 2026-09-08 06:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding a progress overflow protection

Browse Source 
When reporting download progress, we should never have a percentage
bigger than 100%, but if for some reason we do (due to a bug), we don't
want that percentage slipping all the way to the end user.

This commit limits the percentage we display to 100 maximum.

Signed-off-by: Castulo Martinez <castulo.martinez@intel.com>
This commit is contained in:
Castulo Martinez
2019-06-14 14:56:34 -07:00
committed by Otavio Pontes
parent c521417205
commit 0cc96ed702
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/progress.c
+7
View File
@@ -97,6 +97,13 @@ void progress_report(double count, double max)
/* Only print when the percentage changes, so a maximum of 100 times per run */
int percentage = (int)(100 * (count / max));
/* we should never have a percentage bigger than 100% */
if (percentage > 100) {
debug("Progress percentage overflow %d%% (Count: %ld, Max: %ld)\n", percentage, (long)count, (long)max);
return;
}
if (percentage != last_percentage || step.current != last_step) {
if (progress_function) {
progress_function(step.description, step.current, step.total, percentage);