clearlinux/kvmtool
2
0
Fork 0
mirror of https://github.com/clearlinux/kvmtool.git synced 2026-06-16 02:15:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

kvm tools, qcow: Fix copy-on-write image corruption

Browse Source 
We don't handle refcount table properly so make sure we only write to clusters
that have the "copied" flag set.

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
This commit is contained in:
Pekka Enberg
2011-07-20 16:28:31 +03:00
committed by Will Deacon
parent 8259b8cc0d
commit 121dd76e2b
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
disk/qcow.c
+10 -2
View File
@@ -429,7 +429,11 @@ static ssize_t qcow_write_cluster(struct qcow *q, u64 offset, void *buf, u32 src
l2t_off = be64_to_cpu(table->l1_table[l1t_idx]);
if (l2t_off & QCOW_OFLAG_COMPRESSED) {
pr_warning("compressed sectors are not supported");
pr_warning("compressed clusters are not supported");
goto error;
}
if (!(l2t_off & QCOW_OFLAG_COPIED)) {
pr_warning("copy-on-write clusters are not supported");
goto error;
}
@@ -472,7 +476,11 @@ static ssize_t qcow_write_cluster(struct qcow *q, u64 offset, void *buf, u32 src
clust_start = be64_to_cpu(l2t->table[l2t_idx]);
if (clust_start & QCOW_OFLAG_COMPRESSED) {
pr_warning("compressed sectors are not supported");
pr_warning("compressed clusters are not supported");
goto error;
}
if (!(clust_start & QCOW_OFLAG_COPIED)) {
pr_warning("copy-on-write clusters are not supported");
goto error;
}