clearlinux/graphene
2
0
Fork 0
mirror of https://github.com/clearlinux/graphene.git synced 2026-10-03 23:48:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

[LibOS] Disallow mapping outside user address range

Browse Source 
Disallow user program to mmap outside the allowed user address range.
This is especially important for Linux-SGX PAL, since all user-program
memory must be allocated inside of the enclave range (ELRANGE). For
other PALs like Linux and FreeBSD, we probably should enhance PAL
interface (pal_control.user_address) to specify a more meaningful range
(currently the range is from minimal allowed address to address of the
code segment of the PAL library).
This commit is contained in:
Isaku Yamahata
2019-07-19 19:51:15 -07:00
committed by Dmitrii Kuvaiskii
parent 27ca6f0700
commit 96eeefbeda
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
LibOS/shim/src/sys/shim_mmap.c
+13 -4
View File
@@ -70,11 +70,20 @@ void * shim_do_mmap (void * addr, size_t length, int prot, int flags, int fd,
if ((flags & MAP_FIXED) || addr) {
struct shim_vma_val tmp;
if (!lookup_overlap_vma(addr, length, &tmp)) {
debug("mmap: allowing overlapping MAP_FIXED allocation at %p with length %lu\n",
if (addr < PAL_CB(user_address.start) ||
PAL_CB(user_address.end) <= addr ||
(uintptr_t)PAL_CB(user_address.end) - (uintptr_t)addr < length) {
debug("mmap: user specified address %p with length %lu "
"not in allowed user space, ignoring this hint\n",
addr, length);
if (!(flags & MAP_FIXED))
if (flags & MAP_FIXED)
return (void *)-EINVAL;
addr = NULL;
} else if (!lookup_overlap_vma(addr, length, &tmp)) {
if (flags & MAP_FIXED)
debug("mmap: allowing overlapping MAP_FIXED allocation at %p with length %lu\n",
addr, length);
else
addr = NULL;
}
}