clearlinux/graphene
2
0
Fork 0
mirror of https://github.com/clearlinux/graphene.git synced 2026-10-03 15:39:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Pal/*] Remove misleading/old comments in _DkVirtualMemoryAlloc

Browse Source 
The comment said "The memory should have MAP_PRIVATE and MAP_ANONYMOUS"
but depending on the alloc_type parameter the mapping won't be private.
That the mapping will be anonymous is obvious so remove the comment
completely.

Also remove a leftover comment from the initial port to SGX.
This commit is contained in:
Simon Gaiser
2019-03-16 01:00:57 +01:00
committed by Michał Kowalczyk
parent 8346868dfc
commit 75801b0cc7
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Pal/src/host/FreeBSD/db_memory.c
-1
View File
@@ -48,7 +48,6 @@ int _DkVirtualMemoryAlloc (void ** paddr, uint64_t size, int alloc_type,
int flags = HOST_FLAGS(alloc_type, prot|PAL_PROT_WRITECOPY);
prot = HOST_PROT(prot);
/* The memory should have MAP_PRIVATE and MAP_ANONYMOUS */
flags |= MAP_ANONYMOUS|(addr ? MAP_FIXED : 0);
mem = (void *) ARCH_MMAP(addr, size, prot, flags, -1, 0);
Pal/src/host/Linux-SGX/db_memory.c
-6
View File
@@ -70,12 +70,6 @@ int _DkVirtualMemoryAlloc (void ** paddr, uint64_t size, int alloc_type, int pro
{
void * addr = *paddr, * mem;
//int flags = HOST_FLAGS(alloc_type, prot|PAL_PROT_WRITECOPY);
//prot = HOST_PROT(prot);
/* The memory should have MAP_PRIVATE and MAP_ANONYMOUS */
//flags |= MAP_ANONYMOUS|(addr ? MAP_FIXED : 0);
//mem = (void *) ARCH_MMAP(addr, size, prot, flags, -1, 0);
if ((alloc_type & PAL_ALLOC_INTERNAL) && addr)
return -PAL_ERROR_INVAL;
Pal/src/host/Linux/db_memory.c
-1
View File
@@ -48,7 +48,6 @@ int _DkVirtualMemoryAlloc (void ** paddr, uint64_t size, int alloc_type,
int flags = HOST_FLAGS(alloc_type, prot|PAL_PROT_WRITECOPY);
prot = HOST_PROT(prot);
/* The memory should have MAP_PRIVATE and MAP_ANONYMOUS */
flags |= MAP_ANONYMOUS|(addr ? MAP_FIXED : 0);
mem = (void *) ARCH_MMAP(addr, size, prot, flags, -1, 0);