clearlinux/folly
2
0
Fork 0
mirror of https://github.com/clearlinux/folly.git synced 2026-09-01 02:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not construct a Future<T> from a Future<Something> value

Browse Source 
Summary: The value constructor can be nice. But when it matches on Future<Something> it just confuses everybody.

Test Plan:
building and running tests
contbuild

Reviewed By: jsedgwick@fb.com

Subscribers: exa, folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2036455

Tasks: 6925951

Signature: t1:2036455:1430423503:73906f748318c4ebec13f45ad3761f104e2ef888
This commit is contained in:
Hans Fugal
2015-04-30 15:09:05 -07:00
committed by Praveen Kumar Ramakrishnan
parent e4c703f058
commit 5b531cbb45
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
folly/futures/Future-inl.h
+2 -1
View File
@@ -44,7 +44,8 @@ Future<T>& Future<T>::operator=(Future<T>&& other) noexcept {
}
template <class T>
template <class T2>
template <class T2,
typename std::enable_if<!isFuture<T2>::value, void*>::type>
Future<T>::Future(T2&& val) : core_(nullptr) {
Promise<T> p;
p.setValue(std::forward<T2>(val));
folly/futures/Future.h
+3 -1
View File
@@ -56,7 +56,9 @@ class Future {
/// Construct a Future from a value (perfect forwarding)
/* implicit */
template <class T2 = T> Future(T2&& val);
template <class T2 = T,
typename std::enable_if<!isFuture<T2>::value, void*>::type = nullptr>
Future(T2&& val);
template <class T2 = T,
typename std::enable_if<