clearlinux/folly
2
0
Fork 0
mirror of https://github.com/clearlinux/folly.git synced 2026-09-01 11:15:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

We might avoid some temporaries in putMessagesImpl

Browse Source 
Summary:
This is folly github pull request https://github.com/facebook/folly/pull/184

It seems we might avoid some temporaries in putMessagesImpl
function. To do so we pass arguments directly to constructors
with the help of emplace_back member.

Test Plan:
All folly/tests, make check for 37 tests, passed.

Signed-off-by: Nicholas Ormrod <njormrod@fb.com>

Reviewed By: davejwatson@fb.com

Subscribers: folly-diffs@, yfeldblum, chalfant

FB internal diff: D1998515

Tasks: 6783581

Signature: t1:1998515:1429207683:056db129405bed212f50a50821f095c8d3694ec8
This commit is contained in:
Nicholas Ormrod
2015-04-27 16:43:20 -07:00
committed by Alecs King
parent f706bdbd7f
commit 0011d8a063
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
folly/io/async/NotificationQueue.h
+3 -5
View File
@@ -514,9 +514,7 @@ class NotificationQueue {
if (numActiveConsumers_ < numConsumers_) {
signal = true;
}
queue_.push_back(
std::make_pair(std::move(message),
RequestContext::saveContext()));
queue_.emplace_back(std::move(message), RequestContext::saveContext());
}
if (signal) {
signalEvent();
@@ -536,7 +534,7 @@ class NotificationQueue {
if (numActiveConsumers_ < numConsumers_) {
signal = true;
}
queue_.push_back(std::make_pair(message, RequestContext::saveContext()));
queue_.emplace_back(message, RequestContext::saveContext());
}
if (signal) {
signalEvent();
@@ -554,7 +552,7 @@ class NotificationQueue {
folly::SpinLockGuard g(spinlock_);
checkDraining();
while (first != last) {
queue_.push_back(std::make_pair(*first, RequestContext::saveContext()));
queue_.emplace_back(*first, RequestContext::saveContext());
++first;
++numAdded;
}