Add diffstat in required programs check

diffstat is required to geenrate the for-review.txt

Makefile.common

@@ -304,16 +304,21 @@ prekoji-checks:
 koji: prekoji-checks kojidef
 	@$(MAKE) spdxcheck
 	@$(MAKE) checkblacklist
-	@if ! git branch | grep -q -E '^\* master'; then \
+	@if [ "$$(git rev-parse --abbrev-ref HEAD)" != "master" ]; then \
 		echo "Error: Must be on the master branch to submit to koji" >&2; \
 		exit 1; \
 	fi; \
-	if ! git diff --quiet HEAD ${SPECFILE}; then \
+	if ! git diff --quiet HEAD -- ${SPECFILE}; then \
 		echo "Error: All changes to ${SPECFILE} must be committed first" >&2; \
 		exit 1; \
 	fi; \
-	if git rev-parse --verify --quiet origin/master > /dev/null; then \
+	git fetch; \
+	if git rev-parse --verify --quiet origin/master >/dev/null; then \
 		git pull --rebase; \
+	fi; \
+	if git ls-remote --tags --exit-code origin $(SRPMVERS) >/dev/null; then \
+		echo "Error: remote tag $(SRPMVERS) already exists" >&2; \
+		exit 1; \
 	fi
 	git tag $(SRPMVERS)
 	git push origin master refs/tags/$(SRPMVERS)

licenses-spdx

@@ -252,6 +252,7 @@ NPL-1.1
 NPOSL-3.0
 NRL
 NTP
+NTP-0
 Naumen
 Net-SNMP
 NetCDF
@@ -264,7 +265,11 @@ OCLC-2.0
 ODC-By-1.0
 ODbL-1.0
 OFL-1.0
+OFL-1.0-RFN
+OFL-1.0-no-RFN
 OFL-1.1
+OFL-1.1-RFN
+OFL-1.1-no-RFN
 OGL-Canada-2.0
 OGL-UK-1.0
 OGL-UK-2.0
@@ -298,6 +303,7 @@ OpenSSL
 PDDL-1.0
 PHP-3.0
 PHP-3.01
+PSF-2.0
 Parity-6.0.0
 Plexus
 PostgreSQL
@@ -392,6 +398,7 @@ gSOAP-1.3b
 gnuplot
 iMatix
 libpng-2.0
+libselinux-1.0
 libtiff
 mpich2
 psfrag

packages

@@ -31,6 +31,7 @@ HeapDict
 ImageMagick
 JAGS
 Jinja2
+Judy
 Keras
 Keras_Applications
 Keras_Preprocessing
@@ -89,10 +90,12 @@ R-AmesHousing
 R-BB
 R-BBmisc
 R-BH
+R-BMA
 R-BMS
 R-BatchJobs
 R-BayesFactor
 R-BiasedUrn
+R-BiocManager
 R-BoolNet
 R-BradleyTerry2
 R-Brobdingnag
@@ -153,6 +156,7 @@ R-NMF
 R-NMOF
 R-PKI
 R-PerformanceAnalytics
+R-R.cache
 R-R.methodsS3
 R-R.oo
 R-R.utils
@@ -167,6 +171,7 @@ R-RCurl
 R-RInside
 R-RJSONIO
 R-RNeXML
+R-RNetCDF
 R-ROCR
 R-RProtoBuf
 R-RSQLite
@@ -285,6 +290,7 @@ R-cmprsk
 R-cobs
 R-coda
 R-coin
+R-collections
 R-colorspace
 R-colourpicker
 R-combinat
@@ -505,6 +511,7 @@ R-labelled
 R-laeken
 R-lambda.r
 R-languageR
+R-languageserver
 R-lars
 R-later
 R-latticeExtra
@@ -591,6 +598,7 @@ R-mvoutlier
 R-mvtnorm
 R-natserv
 R-ncbit
+R-ncdf4
 R-network
 R-neuralnet
 R-nleqslv
@@ -632,6 +640,7 @@ R-phylobase
 R-phylogram
 R-phytools
 R-pillar
+R-pixmap
 R-pkgKitten
 R-pkgbuild
 R-pkgconfig
@@ -850,6 +859,7 @@ R-tidyverse
 R-tikzDevice
 R-timeDate
 R-timeSeries
+R-tinytest
 R-tinytex
 R-tis
 R-tm
@@ -895,6 +905,7 @@ R-xfun
 R-xml2
 R-xmlparsedata
 R-xopen
+R-xptr
 R-xtable
 R-xts
 R-yaml
@@ -1241,6 +1252,7 @@ chrony
 chrpath
 cifs-utils
 cinder
+clFFT
 clamav
 clear-config-management
 clear-font
@@ -1637,6 +1649,7 @@ font-util
 fontconfig
 fontforge
 fonttools
+fortune-mod
 fossil
 frameworkintegration
 freedv
@@ -1653,6 +1666,7 @@ fuse
 futurist
 fwupd
 fwupdate
+g2fs-utils
 gTTS-token
 gabbi
 garcon
@@ -1698,7 +1712,7 @@ gimp
 girara
 git
 git-gui
-gitdb2
+gitdb
 gitg
 gitolite
 gjs
@@ -1815,6 +1829,7 @@ grep
 grig
 grilo
 grilo-plugins
+grisbi
 groff
 grpc
 grpcio
@@ -1944,6 +1959,7 @@ intervaltree
 intltool
 ioc-cbc-tools
 ioping
+ioport
 iotop
 ipaddr
 ipaddress
@@ -2204,6 +2220,7 @@ kpkpass
 kplotting
 kpty
 kqtquickcharts
+kquickcharts
 krb5
 krdc
 krest
@@ -2376,6 +2393,7 @@ libgpg-error
 libgphoto2
 libgpiod
 libgravatar
+libgsf
 libgsystem
 libgtop
 libgudev
@@ -2576,6 +2594,7 @@ linux-kvm
 linux-libc-headers
 linux-lts2017
 linux-lts2018
+linux-lts2019
 linux-mainline
 linux-oracle
 linux-preempt-rt
@@ -3601,6 +3620,7 @@ oslo.versionedobjects
 oslo.vmware
 oslosphinx
 oslotest
+osm-gps-map
 osprofiler
 ostree
 otp
@@ -4066,6 +4086,7 @@ perl-Log-Any
 perl-Log-Contextual
 perl-Log-Dispatch
 perl-Log-Dispatch-Array
+perl-Log-Dispatch-FileRotate
 perl-Log-Log4perl
 perl-Log-Message
 perl-Log-Message-Simple
@@ -4592,6 +4613,7 @@ postfix
 postgis
 postgresql
 postgresql11
+postgresql12
 potrace
 povray
 powerdevil
@@ -4781,6 +4803,7 @@ qrencode
 qscintilla
 qt-creator
 qt3d
+qt5ct
 qtbase
 qtcanvas3d
 qtcharts
@@ -4836,6 +4859,7 @@ re2
 re2c
 readline
 rebootmgr
+recode
 recommonmark
 redis
 redis-native
@@ -4868,7 +4892,9 @@ retype
 rfc3986
 rfc3987
 rhythmbox
+rinutils
 rjsmin
+rlwrap
 rng-tools
 roboto
 rofi
@@ -4961,7 +4987,7 @@ slurm
 smart_open
 smartcols
 smartmontools
-smmap2
+smmap
 snabb
 snappy
 sndio
@@ -5061,6 +5087,7 @@ swupd-probe
 swupd-search
 sxhkd
 sxiv
+symengine
 sympy
 syndication
 synergy
@@ -5215,6 +5242,7 @@ valgrind
 vbox-integration
 vcstool
 vcversioner
+vifm
 vim
 vim-fugitive
 vim-gnupg

user-setup.sh

@@ -102,7 +102,7 @@ fi
 
 required_progs() {
   local bindir="/usr/bin"
-  for f in git mock rpm rpmbuild ; do
+  for f in git mock rpm rpmbuild diffstat ; do
     [ ! -x "${bindir}/${f}" ] && missing+="${f} "
   done
   [ "$PEM" ] && [ ! -x /usr/bin/koji ] && missing+="koji "