Introduce pre build and koji targets

These are targets to be executed before build and koji targets. They
are meant to execute security and validation checks.

Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>

.gitignore

@@ -0,0 +1,3 @@
+*~
+.*swp
+Makefile*.site_local

Makefile.common

@@ -81,11 +81,13 @@ configemail:
 checkblacklist:
 	@$(TOPLVL)/projects/common/checkblacklist.sh $(TOPLVL)/projects/common/blacklist results/*.rpm
 
+prebuild-checks:
+
 #help build: Builds from current directory on your machine and puts log
 #help files and rpms in the results directory of your package.  If there
 #help are mutlple tar.gz files for a package, make will do make sources,
 #help which creates a src.rpm file from the spec file.
-build: configemail $(SPECFILE) upstream $(SRPMFILE)
+build: prebuild-checks configemail $(SPECFILE) upstream $(SRPMFILE)
 	$(MOCK) $(SRPMFILE) --result=results/ --no-cleanup-after --uniqueext=$(PKG_NAME)
 	@perl $(TOPLVL)/projects/common/logcheck.pl results/build.log
 	@perl $(TOPLVL)/projects/common/count.pl results/build.log &> testresults
@@ -228,10 +230,12 @@ else
 	rm -rf "$$tmp";
 endif
 
+prekoji-checks:
+
 #help koji: Creates a git tag on the latest local commit, then asks koji to
 #help build from that tag on the server. If you have uncommitted local changes,
 #help they will not be included.
-koji: kojidef
+koji: prekoji-checks kojidef
 	@$(MAKE) spdxcheck
 	@$(MAKE) checkblacklist
 	git pull --rebase

README.md

@@ -19,8 +19,9 @@ building Clear Linux packages.
 
 ### Automated setup
 
-Download the [user setup](user-setup.sh) script and run it on your
-Clear Linux system as an unprivileged user.
+Download the [user setup](user-setup.sh) script and run it on your Clear Linux
+system as an unprivileged user. After the script completes, make sure to logout
+and login again to complete the setup process.
 
 The script either accepts no options, or all (3) options in case you are
 configuring the Koji CLI for remote building on a Koji server. The options are

packages

@@ -30,11 +30,11 @@ aspell
 aspell-en
 astroid
 at
+at-spi2-atk
+at-spi2-core
 atk
 atkmm
 atomicwrites
-at-spi2-atk
-at-spi2-core
 attr
 attrs
 audiofile
@@ -84,12 +84,12 @@ btrfs-progs
 bundle-chroot-builder
 bz2file
 bzip2
-cabextract
+c-ares
 ca-certs
 ca-certs-static
+cabextract
 cairo
 cairomm
-c-ares
 cargo
 caribou
 catkin
@@ -117,6 +117,7 @@ clear-containers-shim
 clear-font
 click
 clinfo
+cloudpickle
 clr-boot-manager
 clr-debug-info
 clr-desktop-defaults
@@ -127,9 +128,9 @@ clr-python-timestamp
 clr-R-helpers
 clr-rpm-config
 clr-systemd-config
-clrtrust
 clr-update-triggers
 clr-wallpapers
+clrtrust
 clutter
 clutter-gst
 clutter-gtk
@@ -153,7 +154,6 @@ compat-libical-soname2
 compat-libpng-soname12
 compat-libwebp-soname6
 compat-llvm-soname4
-compat-mpfr-soname4
 compat-opencv-soname32
 compat-opencv-soname33
 compat-readline
@@ -180,7 +180,6 @@ cpuid
 cracklib
 crcmod
 createrepo_c
-c_rehash
 cri-o
 cri-tools
 cryptography
@@ -197,6 +196,7 @@ curl
 cve-check-tool
 cycler
 Cython
+c_rehash
 damageproto
 dapl
 darktable
@@ -292,9 +292,9 @@ fltk
 font-adobe-100dpi
 font-adobe-75dpi
 font-bitstream-type1
+font-util
 fontconfig
 fontsproto
-font-util
 freeglut
 freeipmi
 FreeRDP
@@ -334,9 +334,9 @@ gjs
 glances
 glew
 glib
+glib-networking
 glibc
 glibmm
-glib-networking
 global
 glog
 glproto
@@ -410,13 +410,13 @@ gstreamer
 gstreamer-vaapi
 gsutil
 gtk+
-gtk3
 gtk-doc
+gtk-vnc
+gtk-xfce-engine
+gtk3
 gtkmm3
 gtksourceview
 gtkspell3
-gtk-vnc
-gtk-xfce-engine
 guile
 gvfs
 gvim
@@ -473,15 +473,15 @@ iputils
 ipxe
 ipykernel
 ipython
-ipython_genutils
 ipython-sql
+ipython_genutils
 ipywidgets
 irqbalance
 irrlicht
 irssi
 isa-l
-iso8601
 iso-codes
+iso8601
 isort
 ister
 itstool
@@ -495,15 +495,15 @@ jmespath
 joe
 jq
 json-c
-jsoncpp
 json-glib
+jsoncpp
 jsonschema
 jupyter
+jupyter-nbgallery
+jupyter-notebook-gist
 jupyter_client
 jupyter_console
 jupyter_core
-jupyter-nbgallery
-jupyter-notebook-gist
 kafka-dep
 kbd
 kbproto
@@ -558,8 +558,8 @@ libgfortran-avx
 libgfortran-compat-soname3
 libgit2
 libglade
-libgnomekbd
 libgnome-keyring
+libgnomekbd
 libgpg-error
 libgphoto2
 libgsystem
@@ -694,9 +694,9 @@ lmdb
 logilab-common
 logutils
 lsacpi
-LS_COLORS
 lshw
 lsof
+LS_COLORS
 ltp
 ltrace
 lua
@@ -771,15 +771,15 @@ ncurses-compat
 ndctl
 ndg_httpsclient
 neon
+net-snmp
+net-tools
 netaddr
 netbase
 netcat
 netifaces
-net-snmp
 nettle
-net-tools
-NetworkManager
 network-manager-applet
+NetworkManager
 NetworkManager-openconnect
 networkx
 newt
@@ -807,6 +807,7 @@ ntfs-3g
 numactl
 numba
 numpy
+numpydoc
 nvme-cli
 nvml
 oauth2client
@@ -815,22 +816,22 @@ offlineimap
 olefile
 onig
 opa-psm2
+open-iscsi
+open-isns
+open-lldp
+open-vm-tools
 openal-soft
 openblas
 openconnect
 opencv
-open-iscsi
-open-isns
 openjade
 openjdk
 openldap
-open-lldp
 openmpi
 opensm
 OpenSP
 openssh
 openssl
-open-vm-tools
 openvpn
 openvswitch
 opus
@@ -934,7 +935,6 @@ perl-Sub-Info
 perl-Sub-Quote
 perl-TAP-Harness-Archive
 perl-Term-Table
-perl-Test2-Suite
 perl-Test-Deep
 perl-Test-Fatal
 perl-Test-Needs
@@ -945,6 +945,7 @@ perl-Test-Requires
 perl-Test-Simple
 perl-Test-Taint
 perl-Test-Warnings
+perl-Test2-Suite
 perl-Text-Autoformat
 perl-Text-CSV_XS
 perl-Text-Reform
@@ -1010,8 +1011,8 @@ pycparser
 pycrypto
 pycurl
 pydot
-pydot_ng
 pydotplus
+pydot_ng
 pyflakes
 Pygments
 pygobject
@@ -1021,6 +1022,7 @@ pynacl
 pyOpenSSL
 pyparsing
 pypy
+PyQt5
 pyquery
 pyrfc3339
 pyserial
@@ -1030,7 +1032,6 @@ pytest-runner
 pytest-timeout
 pytest-xdist
 python
-python3
 python-augeas
 python-dateutil
 python-future
@@ -1051,6 +1052,7 @@ python-systemd
 python-tappy
 python-toml
 python-urwid
+python3
 pytz
 pyudev
 PyWavelets
@@ -1061,12 +1063,13 @@ pyzmq
 qemu
 qemu-lite
 qpdf
-qtconsole
 qt-everywhere-opensource-src
+QtAwesome
+qtconsole
+QtPy
 quagga
 quilt
 R
-randrproto
 R-assertthat
 R-backports
 R-BH
@@ -1085,21 +1088,8 @@ R-desc
 R-devtools
 R-dichromat
 R-digest
-rdma-core
 R-dynlm
 R-e1071
-re2c
-readline
-recordproto
-redis
-redis-native
-redsocks
-renderproto
-requests
-resourceproto
-rest
-retry_decorator
-retype
 R-evaluate
 R-foreach
 R-formatR
@@ -1139,16 +1129,13 @@ R-multcomp
 R-munsell
 R-mvtnorm
 R-neuralnet
-rng-tools
 R-nloptr
 R-openssl
 R-pbdZMQ
 R-pbkrtest
-rpcbind
 R-pillar
 R-pkgconfig
 R-plyr
-rpm
 R-png
 R-praise
 R-proto
@@ -1169,7 +1156,6 @@ R-roxygen2
 R-rprojroot
 R-rstudioapi
 R-rversions
-rsa
 R-sandwich
 R-scales
 R-sp
@@ -1177,7 +1163,6 @@ R-SparseM
 R-statmod
 R-stringi
 R-stringr
-rsync
 R-tau
 R-testit
 R-testthat
@@ -1188,9 +1173,6 @@ R-tis
 R-tree
 R-tseries
 R-TTR
-ruby
-runc
-rustc
 R-uuid
 R-viridisLite
 R-whisker
@@ -1198,9 +1180,32 @@ R-withr
 R-XML
 R-xml2
 R-xts
-rxvt-unicode
 R-yaml
 R-zoo
+randrproto
+rdma-core
+re2c
+readline
+recordproto
+redis
+redis-native
+redsocks
+renderproto
+requests
+resourceproto
+rest
+retry_decorator
+retype
+rng-tools
+rope
+rpcbind
+rpm
+rsa
+rsync
+ruby
+runc
+rustc
+rxvt-unicode
 s2tc
 s3transfer
 samba
@@ -1243,6 +1248,7 @@ shim
 siege
 simplegeneric
 simplejson
+sip
 six
 slang
 smartmontools
@@ -1251,6 +1257,7 @@ snappy
 snowballstemmer
 socat
 SocksiPy-branch
+sos
 soundmodem
 source-code-pro
 source-highlight
@@ -1264,6 +1271,8 @@ sphinxcontrib-websupport
 spice
 spice-gtk
 spice-protocol
+spyder
+spyder-notebook
 SQLAlchemy
 sqlite-autoconf
 sqlparse
@@ -1363,8 +1372,8 @@ vim
 vim-go
 vinagre
 virt-manager
-virtualenv
 virt-viewer
+virtualenv
 vlc
 volume_key
 vte
@@ -1403,16 +1412,13 @@ xcb-util
 xcb-util-keysyms
 xclip
 xcmiscproto
-xcursorgen
 xcursor-themes
+xcursorgen
 xdg-user-dirs
 xdg-user-dirs-gtk
 xdg-utils
 xemacs
 xextproto
-xf86bigfontproto
-xf86dgaproto
-xf86driproto
 xf86-input-evdev
 xf86-input-libinput
 xf86-input-mouse
@@ -1423,6 +1429,9 @@ xf86-video-ati
 xf86-video-fbdev
 xf86-video-nouveau
 xf86-video-vesa
+xf86bigfontproto
+xf86dgaproto
+xf86driproto
 xf86vidmodeproto
 xfce4-appfinder
 xfce4-dev-tools