500 Commits
Author SHA1 Message Date
Mark D Horn 2615d0173e gui: tui: storage: Disable the partial adv encrypt support
The support for using encrypted file systems with advanced disk
configuration needs a lot more work.
Tracking new GitHub Issue in #512

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2.2.0
2019-09-12 19:20:47 -07:00
Mark D Horn c190a7169a gui: locale: advanced disk config
The GUI need to be updated to ensure that the user defined state
was updated so that we store the user's answer in the (temp) YAML.

Make the GUI be consistent with the TUI and with the other
two selection labels for the Disk configuration.

Change advanced to warning

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn f6fa4105ad tui: advanced disk config
Use new size checking for advanced partitioning.
Fix logic bug in checking for validation errors before
checking for encryption passphrase.

Code review fixes.

Make advanced description consistent with GUI

New min size and adv labels

Change advanced to warning

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 000e0bdb69 locale: storage: Translate new strings to es_MX and zh_CN
New label for labeled
New translation for passphrase encryption

Based on user feedback switched the tense of installation steps.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn b4c1c98a55 model: Save autoUpdate to the YAML when false
Since we have code which assumes we want autoUpdate to be true
unless it is added to the YAML file, we need to be sure it is
write to the YAML when false.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn a34f01c7d0 test: reduced storage coverage
We've added new functionality to storage which is only
exercised on media when running as root, so dropping
the basic coverage value for storage.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn a0e62a5c11 storage: ensure minimum sizes
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 60f1383fd8 storage: Update test for new method
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 7529a26b4d storage: locale: Validate advanced mounts
Ensure that the advanced extra mount points are
absolute paths and correctly formed.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 5fc0a05f94 storage: update label and uuid after mkfs
The UUID is not set until after the file system is created.
We need to update the block device in memory with the new
UUID to properly create a fstab with UUID instead of device.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 1a45dd24f0 storage: swap fix
Need to mkswap for new swap in advanced

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 77e9ef958c storage: Ensure partition number is set
Write Partition table is setting the partition type
using the partition number, ensure it is set first.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 578106e3fc storage: Always set the GUID
Since we depend upon systemd to mount well-known partitions,
we need to ensure that the GUID is set correctly in the gpt
table for each file system. This is true even if we are
re-using an existing partition.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 5705b636fa storage: Need to set fstype for swap
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 335b5d9741 utils: Bug Fix: Xauth
Check the exit status and collect the results. If we had any failures,
then save a copy of the log file and do not remove the temp files.

Correct how we are enabling root access to the DISPLAY

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 2ebb9e1bd3 utils: gui: tui: Enable clean up temp files
Make use of new command line arg to clean-up the temp
YAML files and install directories.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn bfc624d8fc model: args: Clean up of temp config files
Need a new command line arg to flag for the deletion
of a temp state YAML file.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn bed5c1b706 storage: Add size checking to advanced config
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn b86ff39669 telemetry: model: Only save when user defined
We should only store the telemetry answer when it was
user selected. This fix was needed due to the new advanced
configuration which save the temporary state.

Need to update the ister model for the new change.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 7c04e72f75 storage: Address code review comments
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 93bcb62438 tui: Disable partition tool when no media
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 98089cc36d scripts: sync with devops
Pull in some recent devop changes so the developer test
builds are in-sync.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn c46cf8e3b1 tui: prompt for encryption passphrase
If any of the advanced partitions require encryption, prompt
the use for a passphrase.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn a2216162f0 test: Add model test for new code
No easy way to test all of the error conditions of
Marshaling and Unmarshaling, so dropping the coverage by 1%

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn e7b383fe69 storage: locale: Translate advance partitions
Add translation for advanced partitions as well as new strings
related to the media changes which will be done in confirmation.

Add new tests.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn db3a17c7c6 gui: base media page layout complete
- model: Store precheck status in model
- Refactor sudo user into reusable function
- Enable the partitioning tool button

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 54c5c3949a gui: Show detailed installation summary
Show the user the changes that will happen to media before
confirming the start of the installation.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 29986733df gui: Change InstallSelected to be a map
Change InstallSelected to be a map with the key being
the name of the TargetMedias from the model to support
installing across multiple disks.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 87c554a92c gui: Add disk name to choose list
The disk device name is show in the configured information, but
was missing in the chooser list. User had request this to be able
to differentiate between two drives of the same model.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn e29bc9aa45 utils: Move the lockfile removal after sleep
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 4c3e740e11 utils: Refactor for graphical support
The graphical tool won't usually show the echo statements
in a terminal, so the sleep are an undesired delay.

Added code to enable proper Xauth in the shell script for
running the graphical code as super user in the non-admin
user's desktop.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 7c99f7d9c8 args: tui: gui: --gui flag to force graphics mode
Now check for mutually exclusive options.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 1b1e4cc118 tui: Refactor partition tool for common use
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 5ad0f73b0e utils: helper function to run partitioning tool
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn a1edb51e1d model: Refactor model clean for reuse
Write out the model without media

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn cdc0d85a64 tui: Display advanced configured
Auto-select Media if Advanced still has errors.

Display the Advanced configuration in media screen.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 51d7a479a0 tui: Ensure proper locking for external tool
We need to know the lock file name for use when running
the external partitioning tool.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 9c966e6544 tui: Support multiple disks for Advanced
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 4ead3550d8 tui: Change InstallSelected to be a map
Change InstallSelected to be a map with the key being
the name of the TargetMedias from the model to support
installing across multiple disks.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 7098434b5a storage: Change InstallSelected to be a map
Change InstallSelected to be a map with the key being
the name of the TargetMedias from the model to support
installing across multiple disks.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn b07b16bfd6 tui: Rework of advanced partitioning
Remove the code which was attempting to do the work of many
existing, more reliable disk partitioning tools. The code was
getting overly complex to handle the very high number of options
and corner cases.

The installer will rely on external tools which do a better job.

This will parse the media for advanced partition labels.

Show the user the details of what will change and be used
for the installation.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 142ad41f51 telemetry: tui: gui: allow user default in YAML
If the telemetry value is added to the YAML will set the default
as if the user had selected it in the UI.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn c34252d846 model: Add lock file to model
This is needed to ensure proper locking while running the external
tool for disk partitioning for Advanced disk configuration during
interactive installations.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 0dd83cfe62 storage: Update the partition message
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 2852751add storage: Fix the partition message
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 69abb823ca storage: verify advanced labels
Verify advanced labels to ensure all required are present and
no conflicts.

Add checker for the use of encryption for advanced labels.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 2a130e1897 storage: determine detailed changes to media
Detect the details of the changes to the media to be presented
to the user during the final confirmation step.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 84d88407d9 storage: Support for partition labels
Add partition labels to the lsblk parsed data to enable the
advanced media configuration option. An external tool will be
used to set the partition labels to identify media for use.

Check if a file system is present on each label partition, and if
non is found, use the default file system and flag for formatting.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn b078557b0b media: Validate across multiple media
It is possible that to split the required partitions
across several media.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00
Mark D Horn 25d2144c7c install: save mount point even if not formatting
Previously the mount point would not be saved if formatting
was skipped for the partition.

Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
2019-09-12 19:20:47 -07:00