nica/files: Ensure we really do break on a read error

Previously nc_copy_file would return true regardless of a source read
error, flagged in analysis. Ensure we bypass the set of ret to true and
return the correct value in all instances.

Signed-off-by: Ikey Doherty <michael.i.doherty@intel.com>
This commit is contained in:
Ikey Doherty
2017-03-09 15:44:09 +00:00
parent ac9e0cbefb
commit a8dbe93c7e
+1 -1
View File
@@ -113,7 +113,7 @@ bool nc_copy_file(const char *src, const char *dst, mode_t mode, bool remove_tar
while (true) {
if ((r = read(src_fd, &buffer, sizeof(buffer))) < 0) {
ret = false;
break;
goto end;
}
if (write(dest_fd, buffer, sizeof(buffer)) != r) {
break;