Release v1.13

This release enables yum plugin usage in bundle-chroot-builder.

Signed-off-by: Tudor Marcu <tudor.marcu@intel.com>

README

@@ -1,3 +1,23 @@
+Building this Project
+=====================
+For help using automake see
+http://www.gnu.org/software/automake/manual/html_node/index.html
+
+Configure:
+    aclocal
+    autoconf
+    automake --add-missing
+    # Defaults to /usr/local or specific --prefix=/usr
+    # to overwrite the installed version
+    ./configure
+
+Build:
+    make
+
+Install:
+    make -n install
+    sudo make install
+
 Configuration File
 ==================
 Please update the configuration file paths to point to where your

builder.conf

@@ -1,13 +1,17 @@
 [Builder]
 SERVER_STATE_DIR=/home/clr/mix/update
-BUNDLE_DIR=/home/clr/mix/bundles
+BUNDLE_DIR=/home/clr/mix/mix-bundles
 YUM_CONF=/home/clr/mix/.yum-mix.conf
-CERT=/home/clr/mix/ClearLinuxRoot.pem
-CLEAR_VERSION=VER
-MIX_VERSION=VER
+CERT=/home/clr/mix/Swupd_Root.pem
+VERSIONS_PATH=/home/clr/mix
 
 [swupd]
 BUNDLE=os-core-update
-CONTENTURL=https://download.clearlinux.org/update/
-VERSIONURL=https://download.clearlinux.org/update/
+CONTENTURL=<URL where the content will be hosted>
+VERSIONURL=<URL where the version of the mix will be hosted>
 FORMAT=1
+
+[Server]
+debuginfo_banned=true
+debuginfo_lib=/usr/lib/debug/
+debuginfo_src=/usr/src/debug/

bundle-chroot-builder.py

@@ -25,6 +25,7 @@ import argparse
 import configparser
 import os
 import os.path
+import io
 import platform
 import re
 import shutil
@@ -47,16 +48,32 @@ def handle_options():
     return args
 
 
-def read_config(args):
+def get_config(args):
     buildconf='/usr/share/defaults/bundle-chroot-builder/builder.conf'
     if os.path.isfile('/etc/bundle-chroot-builder/builder.conf'):
         buildconf = '/etc/bundle-chroot-builder/builder.conf'
     if args.config:
         buildconf = args.config
-    config = configparser.ConfigParser()
-    print("Reading from %s" % buildconf)
-    config.read(buildconf)
 
+    print("Reading from %s" % buildconf)
+    cfg_txt = ""
+    # Check that the environment variables in the config file are valid
+    pattern = re.compile("\$\{?(\w+)\}?")
+    for i, line in enumerate(open(buildconf, 'r')):
+        for match in re.finditer(pattern, line):
+            if not match.group(1) in os.environ:
+                print("ERROR:\nbuilder.conf contains an undefined environment variable: %s on line %s\n"
+                        % (i+1, match.group(1)))
+                exit(1)
+        cfg_txt += os.path.expandvars(line)
+
+    config = configparser.ConfigParser()
+    config.readfp(io.StringIO(cfg_txt))
+    return config
+
+
+def read_config(args):
+    config = get_config(args)
     for option in ['SERVER_STATE_DIR', 'BUNDLE_DIR', 'YUM_CONF']:
             if config.has_option('Builder', option) == False:
                 print("ERROR:\nbuilder.conf is missing:\n[Builder]\n%s\n" % option)
@@ -74,9 +91,13 @@ def read_config(args):
 def install_bundle(out_dir, postfix, bundle, bundles, yum_cmd):
     """Helper function to yum install a bundle"""
     lines = []
-    with subprocess.Popen(["m4", bundles + "/" + bundle], cwd=bundles, stdout=subprocess.PIPE, bufsize=1, universal_newlines=True) as p:
-        for line in p.stdout:
-            lines.append(line)
+    try:
+        output = subprocess.check_output(["m4", bundles + "/" + bundle], cwd=bundles, bufsize=1, universal_newlines=True)
+    except subprocess.CalledProcessError as e:
+        print('ERROR {0}: m4 failed on {1}/{2}'.format(e.returncode, bundles, bundle))
+        raise
+    for line in output:
+        lines.append(line)
 
     pkgs = "".join(lines)
     to_install = []
@@ -147,6 +168,37 @@ def clean_bundle(out_dir, bundle, bundles, yum_cmd):
     os.chdir(prev_dir)
 
 
+def write_default_server_ini(state_dir, server_conf):
+    """
+    Write default server.ini file in the state dir in the following format
+
+    [Server]
+    emptydir={state_dir}/empty/
+    imagebase={state_dir}/image/
+    outputdir={state_dir}/www/
+
+    [Debuginfo]
+    banned=true
+    lib=/usr/lib/debug/
+    src=/usr/src/debug/
+    """
+    contents = ("[Server]\n"
+                "emptydir={0}/empty/\n"
+                "imagebase={0}/image/\n"
+                "outputdir={0}/www/\n".format(state_dir))
+    if server_conf:
+        contents += ("\n[Debuginfo]\n"
+                    "banned={}\n"
+                    "lib={}\n"
+                    "src={}\n"
+                    .format(server_conf.get('debuginfo_banned'),
+                            server_conf.get('debuginfo_lib'),
+                            server_conf.get('debuginfo_src')))
+
+    with open(state_dir + "/server.ini", "w+") as serverini:
+        serverini.write(contents)
+
+
 def create_chroots(args, state_dir, bundles, yum_conf):
     """The state_dir should always be created if it does not exist"""
     if os.path.isdir(state_dir) == False:
@@ -160,14 +212,15 @@ def create_chroots(args, state_dir, bundles, yum_conf):
     if os.path.isdir(state_dir + "/www/0") == False:
         os.makedirs(state_dir + "/www/0")
 
-    """Create server.ini and groups.ini for create_update later on"""
-    with open(state_dir + "/server.ini", "w+") as serverini:
-        serverini.write("[Server]\nemptydir=" + state_dir + "/empty/\nimagebase=" + state_dir + "/image/\noutputdir=" + state_dir + "/www/\n")
+    # Create server.ini and groups.ini for create_update later on
+    config = get_config(args)
+    config = config['Server'] if 'Server' in config else {}
+    write_default_server_ini(state_dir, config)
     with open(state_dir + "/groups.ini", "w+") as groupsini:
         bundle_list = os.listdir(bundles)
         bundle_list = trim_bundles(bundle_list)
         for bundle in bundle_list:
-            groupsini.write("[" + bundle + "]\ngroup=" + bundle + "\n\n")
+            groupsini.write("[{0}]\ngroup={0}\n\n".format(bundle))
 
     """Setup chroots for bundles"""
     bversion = ""
@@ -201,7 +254,7 @@ def create_chroots(args, state_dir, bundles, yum_conf):
         packager = ["dnf"]
     else:
         packager = ["yum"]
-    yum_cmd = packager + ["--config={}".format(yum_conf), "-y", "--noplugins", "--releasever={}".format(build_version)]
+    yum_cmd = packager + ["--config={}".format(yum_conf), "-y", "--releasever={}".format(build_version)]
     if 'local' in config == False:
         try:
             urllib.request.urlopen(conf_baseurl)
@@ -284,13 +337,7 @@ def create_chroots(args, state_dir, bundles, yum_conf):
         r.get()
 
     """Read the URL values from builder.conf and insert them into os-core-update to swupd knows where to pull content from"""
-    buildconf='/usr/share/defaults/bundle-chroot-builder/builder.conf'
-    if os.path.isfile('/etc/bundle-chroot-builder/builder.conf'):
-        buildconf = '/etc/bundle-chroot-builder/builder.conf'
-    if args.config:
-        buildconf = args.config
-    config = configparser.ConfigParser()
-    config.read(buildconf)
+    config = get_config(args)
 
     """Read the configuration file for our script values"""
     for option in ['BUNDLE', 'CONTENTURL', 'VERSIONURL', 'FORMAT']:
@@ -331,6 +378,10 @@ def create_chroots(args, state_dir, bundles, yum_conf):
         if package_name not in package_mapping:
             package_mapping[package_name] = set()
         for path in path_list:
+            # RPM prints out a specific string for subpackages that contain no
+            # files. It should be excluded from the SRPM file list.
+            if re.match(br"\(contains no files\)\n", path):
+                continue
             package_mapping[package_name].add(path)
     for package_name, paths in package_mapping.items():
         with open(out_dir + "/files-{}".format(package_name), "wb") as file:

configure.ac

@@ -1,5 +1,5 @@
 AC_PREREQ([2.68])
-AC_INIT([bundle-chroot-builder],[1.07],[tudor.marcu@intel.com],[bundle-chroot-builder])
+AC_INIT([bundle-chroot-builder],[1.13],[tudor.marcu@intel.com],[bundle-chroot-builder])
 AM_INIT_AUTOMAKE([foreign silent-rules color-tests no-dist-gzip dist-xz])
 AC_CONFIG_FILES(Makefile)
 AC_PREFIX_DEFAULT(/usr/local)