OERV-RUNTIME/boringssl
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix potential memory leak.

Browse Source 
This can't happen because we don't implement RSA_PSK, but we probably should
check here.

Probably |sess_cert| shouldn't be attached to SSL_SESSION anyway; it's only
relevant when initializing the session and if it's accessed afterwards, it'll
be shared and cause problems.

Change-Id: Id868e523195f33c22e057f9b89dc02fe68e9b554
Reviewed-on: https://boringssl-review.googlesource.com/1153
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin
2014-07-14 20:49:39 +00:00
committed by Adam Langley
parent 5235f74bc2
commit 0c49ec97f4
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ssl/s3_clnt.c
+5 -1
View File
@@ -1335,7 +1335,11 @@ int ssl3_get_key_exchange(SSL *s)
later.*/
if (s->s3->tmp.new_cipher->algorithm_auth & SSL_aPSK)
{
s->session->sess_cert=ssl_sess_cert_new();
/* PSK ciphersuites that also send a
* Certificate would have already initialized
* |sess_cert|. */
if (s->session->sess_cert == NULL)
s->session->sess_cert = ssl_sess_cert_new();
if (s->session->psk_identity_hint)
{
OPENSSL_free(s->session->psk_identity_hint);