ChuanN-sudo/u-boot
1
0
Fork 0
forked from OERV-BSP/u-boot
Code Pull Requests Activity

i2c: mux: Fix the crash when the i2c-arbitrator node is present

Browse Source 
Observing the crash when we add the i2c-arbitrator node in the device
tree as per the DT bindings. The issue is with the child node of
i2c-arbitrator@72 i.e., i2c@f1950000->i2c-arbitrator@72->i2c-arb, as the
arbitrator uses the uclass of mux(UCLASS_I2C_MUX) and the mux uclass driver
checks for the "reg" property using the i2c_mux_child_post_bind() function,
if it won't find the "reg" property it will return -EINVAL which is leading
to the crash.
So, add the logic to check whether the  child node has the "reg" property,
if the "reg" property exists then read the "reg" and update the channel.

https://www.kernel.org/doc/Documentation/devicetree/bindings/i2c/i2c-arb.txt

Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
This commit is contained in:
Venkatesh Yadav Abbarapu
2025-06-23 13:36:07 +05:30
committed by Tom Rini
parent f3ee5872bf
commit 903eb12323
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/i2c/muxes/i2c-mux-uclass.c
View File

@@ -40,6 +40,11 @@ static int i2c_mux_child_post_bind(struct udevice *dev)
struct i2c_mux_bus *plat = dev_get_parent_plat(dev);
int channel;
ofnode node = dev_ofnode(dev);
if (!ofnode_has_property(node, "reg"))
return 0;
channel = dev_read_u32_default(dev, "reg", -1);
if (channel < 0)
return -EINVAL;