forked from OERV-BSP/u-boot
imx: power-domain: Fix crash due to uninitialized 'id' field
In case of the i.MX8M power-domains (i.MX8MQ, MM, MN) there is only one power-domain for each device. Therefore the 'id' field in struct power_domain should always be zero. Currently if a power-domain is accessed after the initial bind, the 'id' field is left uninitialized. This didn't cause any problems until the following commits were introduced:9086b64ca0("power-domain: Add support for refcounting (again)")a785ef2448("imx: power-domain: Enable refcounting on imx8mp") Now the 'id' field gets accessed in the power_domain_off() sequence and the invalid value causes "Synchronous Abort" failures. This was observed on a i.MX8MM board when running "usb start" and then "usb stop". Fix this issue by setting power_domain->id to '0' in imx8m_power_domain_of_xlate(). Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> Fixes:d08a194871("imx: add support for i.MX8MQ power domain controller") Fixes:9086b64ca0("power-domain: Add support for refcounting (again)") Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
committed by
Fabio Estevam
parent
25140f8908
commit
4a9d6b2e1d
@@ -468,6 +468,8 @@ out_clk_disable:
|
||||
static int imx8m_power_domain_of_xlate(struct power_domain *power_domain,
|
||||
struct ofnode_phandle_args *args)
|
||||
{
|
||||
power_domain->id = 0;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user