1
0
mirror of https://https.git.savannah.gnu.org/git/gnulib.git synced 2026-06-15 23:35:50 +00:00
Files
Paul Eggert fd1daf4e18 glob: match dangling symlinks
This fixes a bug I inadvertently introduced to Gnulib when I
merged glibc glob back into gnulib on 2007-10-16.  This fix is
inspired by a patch proposed for glibc by Adhemerval Zanella in:
https://sourceware.org/ml/libc-alpha/2017-08/msg00446.html
* doc/posix-functions/glob.texi: Update list of affected platforms.
* lib/glob.c (__lstat64): New macro.
(is_dir): New function.
(glob, glob_in_dir): Match symlinks even if they are dangling.
(link_stat, link_exists_p): Remove.  All uses removed.
* lib/glob.in.h (__attribute_noinline__): Remove; no longer used.
* m4/glob.m4 (gl_PREREQ_GLOB): Do not check for fstatat.
* modules/glob (Depends-on): Remove dirfd.
* modules/glob-tests (Depends-on): Add symlink.
* tests/test-glob.c: Include errno.h, unistd.h.
(BASE): New macro.
(main): Test dangling symlinks, if symlinks are supported.
2017-08-31 15:08:44 -07:00

98 lines
2.8 KiB
C

/* Test of glob/globfree functions.
Copyright (C) 2009-2017 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
/* Written by Simon Josefsson <simon@josefsson.org>, 2009. */
#include <config.h>
#include <glob.h>
#include <errno.h>
#include <unistd.h>
#include "signature.h"
SIGNATURE_CHECK (glob, int, (char const *, int, int (*) (char const *, int),
glob_t *));
SIGNATURE_CHECK (globfree, void, (glob_t *));
#include <string.h>
#include "macros.h"
#define BASE "test-glob.t"
#define GL_NO_SUCH_FILE "/gnulib-magic-does-not-exist"
int
main ()
{
int res;
glob_t g;
/* Make sure glob_t struct members exists. */
ASSERT (sizeof (g.gl_pathc));
ASSERT (sizeof (g.gl_pathv));
ASSERT (sizeof (g.gl_offs));
res = glob (".", 0, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 1);
globfree (&g);
res = glob (".", GLOB_NOSORT, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 1);
globfree (&g);
res = glob (".", GLOB_MARK, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 1);
res = glob (".", GLOB_APPEND, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 2);
globfree (&g);
res = glob (".", GLOB_NOESCAPE, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 1);
globfree (&g);
res = glob ("./*", 0, NULL, &g);
ASSERT (res == 0 && g.gl_pathc >= 1);
globfree (&g);
res = glob (GL_NO_SUCH_FILE, 0, NULL, &g);
ASSERT (res == GLOB_NOMATCH);
res = glob (GL_NO_SUCH_FILE, GLOB_NOCHECK, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 1);
ASSERT (strcmp (g.gl_pathv[0], GL_NO_SUCH_FILE) == 0);
globfree (&g);
if ((symlink (GL_NO_SUCH_FILE, BASE "globlink1") == 0 || errno == EEXIST)
&& (symlink (".", BASE "globlink2") == 0 || errno == EEXIST))
{
res = glob (BASE "globlink[12]", 0, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 2);
ASSERT (strcmp (g.gl_pathv[0], BASE "globlink1") == 0);
ASSERT (strcmp (g.gl_pathv[1], BASE "globlink2") == 0);
globfree (&g);
res = glob (BASE "globlink[12]", GLOB_MARK, NULL, &g);
ASSERT (res == 0 && g.gl_pathc == 2);
ASSERT (strcmp (g.gl_pathv[0], BASE "globlink1") == 0);
ASSERT (strcmp (g.gl_pathv[1], BASE "globlink2/") == 0);
globfree (&g);
}
return 0;
}