Cole Robinson
823c0cc7e3
CVE-2019-10161: arbitrary file read/exec via virDomainSaveImageGetXMLDesc API (bz #1722463, bz #1720115) CVE-2019-10166: virDomainManagedSaveDefineXML API exposed to readonly clients (bz #1722462, bz #1720114) CVE-2019-10167: arbitrary command execution via virConnectGetDomainCapabilities API (bz #1722464, bz #1720117) CVE-2019-10168: arbitrary command execution via virConnectBaselineHypervisorCPU and virConnectCompareHypervisorCPU APIs (bz #1722466, bz #1720118) CVE-2019-3886: virsh domhostname command discloses guest hostname in readonly mode [fedora-rawhide Failed to attache NEW rbd device to guest (bz #1672620) PCI hostdev interface segfault (bz #1692053)
30 lines
1.2 KiB
Diff
30 lines
1.2 KiB
Diff
From: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
|
|
Date: Tue, 22 Jan 2019 12:26:15 -0700
|
|
Subject: [PATCH] util: Fixing invalid error checking from virPCIGetNetname()
|
|
|
|
The @linkdev is In/Out function parameter as second order
|
|
reference pointer so requires first order dereference for
|
|
checking NULL which can be the result of virPCIGetNetName().
|
|
|
|
Fixes: d6ee56d7237 (util: change virPCIGetNetName() to not return error if device has no net name)
|
|
Signed-off-by: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
|
|
Signed-off-by: dann frazier <dann.frazier@canonical.com>
|
|
(cherry picked from commit 04983c3c6a821f67994b1c65d4d6175f3ac49d69)
|
|
---
|
|
src/util/virhostdev.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
|
|
index ca79c37787..d9a3711386 100644
|
|
--- a/src/util/virhostdev.c
|
|
+++ b/src/util/virhostdev.c
|
|
@@ -319,7 +319,7 @@ virHostdevNetDevice(virDomainHostdevDefPtr hostdev,
|
|
if (virPCIGetNetName(sysfs_path, 0, NULL, linkdev) < 0)
|
|
return -1;
|
|
|
|
- if (!linkdev) {
|
|
+ if (!(*linkdev)) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("The device at %s has no network device name"),
|
|
sysfs_path);
|