Florian Fainelli
04ca5dc2cd
Update 0005-Correct-loop-function-signature.patch to include a named
parameter otherwise the following compiler warning turned error is
triggered:
busy.c:6:1: error: parameter name omitted
void *loop(void *)
^~~~
Interestingly, this builds with GCC > 10.x, but fails fails with GCC
<= 10.
Fixes: https://autobuild.buildroot.org/results/8592e4eb5959124acc885a1cbc2f9d24fb7bcbd1
Fixes: https://autobuild.buildroot.org/results/cf12d080ddd7a2398a79be430d935071ca3250a3/
Fixes: e63181bc00 ("package/cpulimit: Backport fix for function signature")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
50 lines
1.3 KiB
Diff
50 lines
1.3 KiB
Diff
From e94b6dd7b3ca884f72f02879fd85792a3aee961d Mon Sep 17 00:00:00 2001
|
|
From: Florian Fainelli <f.fainelli@gmail.com>
|
|
Date: Wed, 2 Jul 2025 20:47:58 -0700
|
|
Subject: [PATCH] Correct loop function signature
|
|
|
|
loop is passed to pthread_create() which requires the following
|
|
prototype to be used: void *(*start_routine) (void *)
|
|
|
|
Correct the signature to avoid such warnings:
|
|
|
|
In file included from busy.c:3:
|
|
/home/buildroot/instance-0/output-1/host/mips-buildroot-linux-uclibc/sysroot/usr/include/pthread.h:164:36: note: expected 'void * (*)(void *)' but argument is of type 'void * (*)(void)'
|
|
164 | void *(*__start_routine) (void *),
|
|
| ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
|
|
busy.c:6:7: note: 'loop' declared here
|
|
6 | void *loop()
|
|
| ^~~~
|
|
|
|
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
Upstream: https://github.com/opsengine/cpulimit/pull/127
|
|
---
|
|
tests/busy.c | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/tests/busy.c b/tests/busy.c
|
|
index b3afb7cd853b..8acbcd82e04f 100644
|
|
--- a/tests/busy.c
|
|
+++ b/tests/busy.c
|
|
@@ -3,7 +3,7 @@
|
|
#include <pthread.h>
|
|
#include <unistd.h>
|
|
|
|
-void *loop()
|
|
+void *loop(void *unused)
|
|
{
|
|
while(1);
|
|
}
|
|
@@ -23,7 +23,7 @@ int main(int argc, char **argv) {
|
|
exit(1);
|
|
}
|
|
}
|
|
- loop();
|
|
+ loop(NULL);
|
|
return 0;
|
|
}
|
|
|
|
--
|
|
2.43.0
|
|
|