f826edeb88
Patch series "samples/damon: fix boot time enable handling fixup merge mistakes". First three patches of the patch series "mm/damon: fix misc bugs in DAMON modules" [1] were trying to fix boot time DAMON sample modules enabling issues. The issues are the modules can crash if those are enabled before DAMON is enabled, like using boot time parameter options. The three patches were fixing the issues by avoiding starting DAMON before the module initialization phase. However, probably by a mistake during a merge, only half of the change is merged, and the part for avoiding the starting of DAMON before the module initialized is missed. So the problem is not solved and thus the modules can still crash if enabled before DAMON is initialized. Fix those by applying the unmerged parts again. Note that the broken commits are merged into 6.17-rc1, but also backported to relevant stable kernels. So this series also needs to be merged into the stable kernels. Hence Cc-ing stable@. This patch (of 3): Commit0ed1165c37("samples/damon/wsse: fix boot time enable handling") is somehow incompletely applying the origin patch [2]. It is missing the part that avoids starting DAMON before module initialization. Probably a mistake during a merge has happened. Fix it by applying the missed part again. Link: https://lkml.kernel.org/r/20250909022238.2989-1-sj@kernel.org Link: https://lkml.kernel.org/r/20250909022238.2989-2-sj@kernel.org Link: https://lkml.kernel.org/r/20250706193207.39810-1-sj@kernel.org [1] Link: https://lore.kernel.org/20250706193207.39810-2-sj@kernel.org [2] Fixes:0ed1165c37("samples/damon/wsse: fix boot time enable handling") Signed-off-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
147 lines
2.8 KiB
C
147 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* working set size estimation: monitor access pattern of given process and
|
|
* print estimated working set size (total size of regions that showing some
|
|
* access).
|
|
*/
|
|
|
|
#define pr_fmt(fmt) "damon_sample_wsse: " fmt
|
|
|
|
#include <linux/damon.h>
|
|
#include <linux/init.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
|
|
#ifdef MODULE_PARAM_PREFIX
|
|
#undef MODULE_PARAM_PREFIX
|
|
#endif
|
|
#define MODULE_PARAM_PREFIX "damon_sample_wsse."
|
|
|
|
static int target_pid __read_mostly;
|
|
module_param(target_pid, int, 0600);
|
|
|
|
static int damon_sample_wsse_enable_store(
|
|
const char *val, const struct kernel_param *kp);
|
|
|
|
static const struct kernel_param_ops enabled_param_ops = {
|
|
.set = damon_sample_wsse_enable_store,
|
|
.get = param_get_bool,
|
|
};
|
|
|
|
static bool enabled __read_mostly;
|
|
module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
|
|
MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_WSSE");
|
|
|
|
static struct damon_ctx *ctx;
|
|
static struct pid *target_pidp;
|
|
|
|
static int damon_sample_wsse_repeat_call_fn(void *data)
|
|
{
|
|
struct damon_ctx *c = data;
|
|
struct damon_target *t;
|
|
|
|
damon_for_each_target(t, c) {
|
|
struct damon_region *r;
|
|
unsigned long wss = 0;
|
|
|
|
damon_for_each_region(r, t) {
|
|
if (r->nr_accesses > 0)
|
|
wss += r->ar.end - r->ar.start;
|
|
}
|
|
pr_info("wss: %lu\n", wss);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static struct damon_call_control repeat_call_control = {
|
|
.fn = damon_sample_wsse_repeat_call_fn,
|
|
.repeat = true,
|
|
};
|
|
|
|
static int damon_sample_wsse_start(void)
|
|
{
|
|
struct damon_target *target;
|
|
int err;
|
|
|
|
pr_info("start\n");
|
|
|
|
ctx = damon_new_ctx();
|
|
if (!ctx)
|
|
return -ENOMEM;
|
|
if (damon_select_ops(ctx, DAMON_OPS_VADDR)) {
|
|
damon_destroy_ctx(ctx);
|
|
return -EINVAL;
|
|
}
|
|
|
|
target = damon_new_target();
|
|
if (!target) {
|
|
damon_destroy_ctx(ctx);
|
|
return -ENOMEM;
|
|
}
|
|
damon_add_target(ctx, target);
|
|
target_pidp = find_get_pid(target_pid);
|
|
if (!target_pidp) {
|
|
damon_destroy_ctx(ctx);
|
|
return -EINVAL;
|
|
}
|
|
target->pid = target_pidp;
|
|
|
|
err = damon_start(&ctx, 1, true);
|
|
if (err)
|
|
return err;
|
|
repeat_call_control.data = ctx;
|
|
return damon_call(ctx, &repeat_call_control);
|
|
}
|
|
|
|
static void damon_sample_wsse_stop(void)
|
|
{
|
|
pr_info("stop\n");
|
|
if (ctx) {
|
|
damon_stop(&ctx, 1);
|
|
damon_destroy_ctx(ctx);
|
|
}
|
|
}
|
|
|
|
static bool init_called;
|
|
|
|
static int damon_sample_wsse_enable_store(
|
|
const char *val, const struct kernel_param *kp)
|
|
{
|
|
bool is_enabled = enabled;
|
|
int err;
|
|
|
|
err = kstrtobool(val, &enabled);
|
|
if (err)
|
|
return err;
|
|
|
|
if (enabled == is_enabled)
|
|
return 0;
|
|
|
|
if (enabled) {
|
|
if (!init_called)
|
|
return 0;
|
|
|
|
err = damon_sample_wsse_start();
|
|
if (err)
|
|
enabled = false;
|
|
return err;
|
|
}
|
|
damon_sample_wsse_stop();
|
|
return 0;
|
|
}
|
|
|
|
static int __init damon_sample_wsse_init(void)
|
|
{
|
|
int err = 0;
|
|
|
|
init_called = true;
|
|
if (enabled) {
|
|
err = damon_sample_wsse_start();
|
|
if (err)
|
|
enabled = false;
|
|
}
|
|
return err;
|
|
}
|
|
|
|
module_init(damon_sample_wsse_init);
|