kernel: add a helper to get an owning user namespace for a namespace
Return -EPERM if an owning user namespace is outside of a process
current user namespace.
v2: In a first version ns_get_owner returned ENOENT for init_user_ns.
This special cases was removed from this version. There is nothing
outside of init_user_ns, so we can return EPERM.
v3: rename ns->get_owner() to ns->owner(). get_* usually means that it
grabs a reference.
Acked-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Andrei Vagin <avagin@openvz.org>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
This commit is contained in:
committed by
Eric W. Biederman
parent
29b4817d40
commit
bcac25a58b
@@ -6403,12 +6403,18 @@ static void cgroupns_put(struct ns_common *ns)
|
||||
put_cgroup_ns(to_cg_ns(ns));
|
||||
}
|
||||
|
||||
static struct user_namespace *cgroupns_owner(struct ns_common *ns)
|
||||
{
|
||||
return to_cg_ns(ns)->user_ns;
|
||||
}
|
||||
|
||||
const struct proc_ns_operations cgroupns_operations = {
|
||||
.name = "cgroup",
|
||||
.type = CLONE_NEWCGROUP,
|
||||
.get = cgroupns_get,
|
||||
.put = cgroupns_put,
|
||||
.install = cgroupns_install,
|
||||
.owner = cgroupns_owner,
|
||||
};
|
||||
|
||||
static __init int cgroup_namespaces_init(void)
|
||||
|
||||
@@ -388,12 +388,18 @@ static int pidns_install(struct nsproxy *nsproxy, struct ns_common *ns)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct user_namespace *pidns_owner(struct ns_common *ns)
|
||||
{
|
||||
return to_pid_ns(ns)->user_ns;
|
||||
}
|
||||
|
||||
const struct proc_ns_operations pidns_operations = {
|
||||
.name = "pid",
|
||||
.type = CLONE_NEWPID,
|
||||
.get = pidns_get,
|
||||
.put = pidns_put,
|
||||
.install = pidns_install,
|
||||
.owner = pidns_owner,
|
||||
};
|
||||
|
||||
static __init int pid_namespaces_init(void)
|
||||
|
||||
@@ -1004,12 +1004,36 @@ static int userns_install(struct nsproxy *nsproxy, struct ns_common *ns)
|
||||
return commit_creds(cred);
|
||||
}
|
||||
|
||||
struct ns_common *ns_get_owner(struct ns_common *ns)
|
||||
{
|
||||
struct user_namespace *my_user_ns = current_user_ns();
|
||||
struct user_namespace *owner, *p;
|
||||
|
||||
/* See if the owner is in the current user namespace */
|
||||
owner = p = ns->ops->owner(ns);
|
||||
for (;;) {
|
||||
if (!p)
|
||||
return ERR_PTR(-EPERM);
|
||||
if (p == my_user_ns)
|
||||
break;
|
||||
p = p->parent;
|
||||
}
|
||||
|
||||
return &get_user_ns(owner)->ns;
|
||||
}
|
||||
|
||||
static struct user_namespace *userns_owner(struct ns_common *ns)
|
||||
{
|
||||
return to_user_ns(ns)->parent;
|
||||
}
|
||||
|
||||
const struct proc_ns_operations userns_operations = {
|
||||
.name = "user",
|
||||
.type = CLONE_NEWUSER,
|
||||
.get = userns_get,
|
||||
.put = userns_put,
|
||||
.install = userns_install,
|
||||
.owner = userns_owner,
|
||||
};
|
||||
|
||||
static __init int user_namespaces_init(void)
|
||||
|
||||
@@ -130,10 +130,16 @@ static int utsns_install(struct nsproxy *nsproxy, struct ns_common *new)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct user_namespace *utsns_owner(struct ns_common *ns)
|
||||
{
|
||||
return to_uts_ns(ns)->user_ns;
|
||||
}
|
||||
|
||||
const struct proc_ns_operations utsns_operations = {
|
||||
.name = "uts",
|
||||
.type = CLONE_NEWUTS,
|
||||
.get = utsns_get,
|
||||
.put = utsns_put,
|
||||
.install = utsns_install,
|
||||
.owner = utsns_owner,
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user