perf mmap: Simplify perf_mmap__read_event()
It isn't necessary to pass the 'overwrite', 'start' and 'end' argument to perf_mmap__read_event(). Discard them. Signed-off-by: Kan Liang <kan.liang@linux.intel.com> Suggested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Andi Kleen <ak@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/r/1520350567-80082-7-git-send-email-kan.liang@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
committed by
Arnaldo Carvalho de Melo
parent
d6ace3df43
commit
0019dc87b9
@@ -36,7 +36,7 @@ static int count_samples(struct perf_evlist *evlist, int *sample_count,
|
||||
u64 start, end;
|
||||
|
||||
perf_mmap__read_init(map, true, &start, &end);
|
||||
while ((event = perf_mmap__read_event(map, true, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(map)) != NULL) {
|
||||
const u32 type = event->header.type;
|
||||
|
||||
switch (type) {
|
||||
|
||||
@@ -183,7 +183,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
continue;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
const u32 type = event->header.type;
|
||||
|
||||
if (type == PERF_RECORD_SAMPLE)
|
||||
|
||||
@@ -418,7 +418,7 @@ static int process_events(struct machine *machine, struct perf_evlist *evlist,
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
continue;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
ret = process_event(machine, evlist, event, state);
|
||||
perf_mmap__consume(md);
|
||||
if (ret < 0)
|
||||
|
||||
@@ -36,7 +36,7 @@ static int find_comm(struct perf_evlist *evlist, const char *comm)
|
||||
md = &evlist->mmap[i];
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
continue;
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
if (event->header.type == PERF_RECORD_COMM &&
|
||||
(pid_t)event->comm.pid == getpid() &&
|
||||
(pid_t)event->comm.tid == getpid() &&
|
||||
|
||||
@@ -112,7 +112,7 @@ int test__basic_mmap(struct test *test __maybe_unused, int subtest __maybe_unuse
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
goto out_init;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
struct perf_sample sample;
|
||||
|
||||
if (event->header.type != PERF_RECORD_SAMPLE) {
|
||||
|
||||
@@ -93,7 +93,7 @@ int test__syscall_openat_tp_fields(struct test *test __maybe_unused, int subtest
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
continue;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
const u32 type = event->header.type;
|
||||
int tp_flags;
|
||||
struct perf_sample sample;
|
||||
|
||||
@@ -171,7 +171,7 @@ int test__PERF_RECORD(struct test *test __maybe_unused, int subtest __maybe_unus
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
continue;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
const u32 type = event->header.type;
|
||||
const char *name = perf_event__name(type);
|
||||
|
||||
|
||||
@@ -99,7 +99,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
goto out_init;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
struct perf_sample sample;
|
||||
|
||||
if (event->header.type != PERF_RECORD_SAMPLE)
|
||||
|
||||
@@ -267,7 +267,7 @@ static int process_events(struct perf_evlist *evlist,
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
continue;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
cnt += 1;
|
||||
ret = add_event(evlist, &events, event);
|
||||
perf_mmap__consume(md);
|
||||
|
||||
@@ -116,7 +116,7 @@ retry:
|
||||
if (perf_mmap__read_init(md, false, &start, &end) < 0)
|
||||
goto out_init;
|
||||
|
||||
while ((event = perf_mmap__read_event(md, false, &start, end)) != NULL) {
|
||||
while ((event = perf_mmap__read_event(md)) != NULL) {
|
||||
if (event->header.type == PERF_RECORD_EXIT)
|
||||
nr_exit++;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user