From d38edd839ec5b009081e357760ec34917fda0a71 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Mon, 27 Oct 2014 17:17:32 +0100 Subject: [PATCH] Don't lower security standards with gcc 4.9 For some reason since e4d65c07cee90461caad8b24f069fc93a82c3877 we started compiling -Wno-format, possibly because of plugins dependencies not compiling. Fedora (and Debian to some degrees) are starting to default to -Wformat -Werror=format-security which is something sensible for uwsgi. So let the distro handle the situation when a very recent gcc version is encountered since they probably know better. --- uwsgiconfig.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uwsgiconfig.py b/uwsgiconfig.py index 84e8ef15..5db535df 100644 --- a/uwsgiconfig.py +++ b/uwsgiconfig.py @@ -698,7 +698,7 @@ class uConf(object): # add -fno-strict-aliasing only on python2 and gcc < 4.3 if gcc_major >= 4: self.cflags = self.cflags + [ '-Wextra', '-Wno-unused-parameter', '-Wno-missing-field-initializers' ] - if (gcc_major == 4 and gcc_minor >= 8) or gcc_major > 4: + if gcc_major == 4 and gcc_minor < 9: self.cflags.append('-Wno-format -Wno-format-security') self.ldflags = os.environ.get("LDFLAGS", "").split()