clearlinux/uwsgi
2
0
Fork 0
mirror of https://github.com/clearlinux/uwsgi.git synced 2026-09-06 21:51:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

plugin/python: fix some leaks on error paths in symimporter

Browse Source 
Reported by Coverity as CID #971059, #971060.
This commit is contained in:
Riccardo Magliocchetti
2013-01-27 12:36:54 +01:00
parent 0cb2e6852b
commit 43ee6a305f
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/python/symimporter.c
+16 -11
View File
@@ -466,6 +466,7 @@ zipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds)
PyObject *stringio = PyImport_ImportModule("StringIO");
if (!stringio) {
free(body);
return -1;
}
@@ -572,18 +573,18 @@ symzipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds
char *code_start = name_to_symbol(name, "start");
if (!code_start) {
PyErr_Format(PyExc_ValueError, "unable to find symbol");
return -1;
goto error;
}
char *code_end = name_to_symbol(name, "end");
if (!code_end) {
PyErr_Format(PyExc_ValueError, "unable to find symbol");
return -1;
goto error;
}
PyObject *stringio = PyImport_ImportModule("StringIO");
if (!stringio) {
return -1;
goto error;
}
#ifdef PYTHREE
@@ -591,12 +592,12 @@ symzipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds
#else
PyObject *stringio_dict = PyModule_GetDict(stringio);
if (!stringio_dict) {
return -1;
goto error;
}
PyObject *stringio_stringio = PyDict_GetItemString(stringio_dict, "StringIO");
if (!stringio_stringio) {
return -1;
goto error;
}
PyObject *stringio_args = PyTuple_New(1);
@@ -606,12 +607,12 @@ symzipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds
PyObject *source_code = PyInstance_New(stringio_stringio, stringio_args, NULL);
#endif
if (!source_code) {
return -1;
goto error;
}
PyObject *zipfile = PyImport_ImportModule("zipfile");
if (!zipfile) {
return -1;
goto error;
}
#ifdef PYTHREE
@@ -619,12 +620,12 @@ symzipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds
#else
PyObject *zipfile_dict = PyModule_GetDict(zipfile);
if (!zipfile_dict) {
return -1;
goto error;
}
PyObject *zipfile_zipfile = PyDict_GetItemString(zipfile_dict, "ZipFile");
if (!zipfile_zipfile) {
return -1;
goto error;
}
PyObject *zipfile_args = PyTuple_New(1);
@@ -634,14 +635,14 @@ symzipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds
self->zip = PyInstance_New(zipfile_zipfile, zipfile_args, NULL);
#endif
if (!self->zip) {
return -1;
goto error;
}
Py_INCREF(self->zip);
self->items = PyObject_CallMethod(self->zip, "namelist", NULL);
if (!self->items) {
return -1;
goto error;
}
Py_INCREF(self->items);
@@ -654,6 +655,10 @@ symzipimporter_init(struct _symzipimporter *self, PyObject *args, PyObject *kwds
return 0;
error:
free(name);
return -1;
}
static PyTypeObject SymZipImporter_Type = {