Patrick McCarty
cbbc579917
journal probe: conditionally enable log level filters
...
Because log messages from services contain arbitrary data, and sometimes
this data is privacy sensitive, only enable the log level filters when
the privacy filter override is in effect.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-06-30 14:33:31 -07:00
Patrick McCarty
15a32b6346
Fix code style issues in journal.c
...
Run uncrustify again to catch further whitespace issues.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-05-11 10:29:18 -07:00
Patrick McCarty
f3a641b161
Use getopt_long() in the journal probe
...
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-05-10 12:54:43 -07:00
Patrick McCarty
eedcb88cb7
Run uncrustify
...
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-05-10 12:07:44 -07:00
Patrick McCarty
787102c4fb
Clean up makefile and header references for consistency
...
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-05-10 11:58:55 -07:00
Arjan van de Ven
f354078d3d
convert the journal probe to getopt
2017-05-10 11:27:52 -07:00
Arjan van de Ven
db85aa9a18
stop using g_print
2017-05-10 11:27:52 -07:00
Arjan van de Ven
365cfeee9a
convert the journal probe to nica strings
2017-05-10 11:27:52 -07:00
Arjan van de Ven
6295f0f4dc
a gchar is just a char typedef
2017-05-05 12:18:42 -07:00
Patrick McCarty
9b435f39e5
journal probe: remove obsolete LOG_DEBUG message
...
A return value of 0 can also indicate send_data() failure, so remove
this log message.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
20c051fe59
Document the logical expression for journal entry matching
...
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
96c1cd5547
journal probe: filter LOG_EMERG logs as well
...
I omitted log level 0 from the filter, so add it here.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
e375fe6825
journal probe: send records for every log message
...
The previous logic concatenates log messages on initial startup, when
the entire journal is read to process existing messages. But doing so
might run into the payload size limit (8KB), and thus fail to create a
record.
Sending one record per log message will ensure that the payload size
remains relatively small, almost always below the 8KB size limit.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
160a4d01bf
journal probe: filter on EXIT_CODE as well
...
This field appears to be set when services fail, so filter on it as
well.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
3f7b839cd8
journal probe: use the new macros
...
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
07595885c4
journal probe: add macros to help with using the journal API
...
To avoid having to read the repetitive error handling when adding
journal filters, add some helper macros.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
625eea615e
journal probe: fix formatting of some log messages
...
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
8a69b22895
journal probe: add newlines for to each message in the payload
...
The make payloads more legible, make sure separate messages are newline
separated.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
b4a0989d0e
journal probe: match all messages ERR or higher
...
Previous behavior was to only filter LOG_ERR messages from the
telemetrics crashprobe, but it will be helpful to make this probe more
generic to capture log messages with the highest log levels.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Patrick McCarty
41f53507d1
journal probe: fix error handling of read_new_entries()
...
The error case is negative, so fix the return code conditional check
appropriately.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com >
2017-02-17 11:35:25 -08:00
Robert Nesius
89c62aae4a
First Commit
2016-07-01 20:16:54 +00:00