diff --git a/src/shared/conf-files.c b/src/shared/conf-files.c index 59bc8ceed..780ce1a17 100644 --- a/src/shared/conf-files.c +++ b/src/shared/conf-files.c @@ -37,20 +37,16 @@ #include "hashmap.h" #include "conf-files.h" -static int files_add(Hashmap *h, const char *dirpath, const char *suffix, const char *root) { +static int files_add(Hashmap *h, const char *root, const char *path, const char *suffix) { _cleanup_closedir_ DIR *dir = NULL; + char *dirpath; - assert(dirpath); + assert(path); assert(suffix); - if (isempty(root)) - dir = opendir(dirpath); - else { - const char *p; + dirpath = strappenda(root ? root : "", path); - p = strappenda3(root, "/", dirpath); - dir = opendir(p); - } + dir = opendir(dirpath); if (!dir) { if (errno == ENOENT) return 0; @@ -118,7 +114,7 @@ static int conf_files_list_strv_internal(char ***strv, const char *suffix, const return -ENOMEM; STRV_FOREACH(p, dirs) { - r = files_add(fh, *p, suffix, root); + r = files_add(fh, root, *p, suffix); if (r == -ENOMEM) { hashmap_free_free(fh); return r; diff --git a/src/shared/install.c b/src/shared/install.c index bce906793..2f83429e4 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -1772,7 +1772,7 @@ UnitFileState unit_file_get_state( int unit_file_query_preset(UnitFileScope scope, const char *name) { _cleanup_strv_free_ char **files = NULL; - char **i; + char **p; int r; assert(scope >= 0); @@ -1800,10 +1800,10 @@ int unit_file_query_preset(UnitFileScope scope, const char *name) { if (r < 0) return r; - STRV_FOREACH(i, files) { + STRV_FOREACH(p, files) { _cleanup_fclose_ FILE *f; - f = fopen(*i, "re"); + f = fopen(*p, "re"); if (!f) { if (errno == ENOENT) continue;