Shellcheck is a shell script static analysis tool that looks for errors and
programming pitfalls in shell scripts.
Fixing errors reported by running that tool on bats scripts
Signed-off-by: Otavio Pontes <otavio.pontes@intel.com>
Using `git diff-index` is problematic for this test, because manpages
regenerated by `make` will have a modified mtime, and `git diff-index`
(being a low-level command) does not refresh the file's mtime stored in
the index. Refreshing the mtime and other stat information stored in the
index is something that happens automatically for high-level "porcelain"
commands.
Since `git diff` will suffice for checking that no uncommitted changes
to manpages exist, use it instead.
Also, use the --exit-code option instead to see the diff output in case
of failure.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
This test is unreliable and fails seemingly randomly in our CI.
Restarting our tests always makes the test pass.
Signed-off-by: Matthew Johnson <matthew.johnson@intel.com>
Current idea is to have the manual pages stored in the repo in nroff
format, as well as restructured test format. Users can just use the
nroff. Add test to ensure that the pages match.
Fixes#316Fixes#425
Make sure that running "make" hasn't fixed the local manual pages but
not checked them in.
Signed-off-by: Icarus Sparry <icarus.w.sparry@intel.com>
Otavio Pontes