From f7ef320b6a0ee3905fd41cf6e45ef2dc635ff196 Mon Sep 17 00:00:00 2001 From: Castulo Martinez Date: Mon, 17 Sep 2018 15:08:43 -0700 Subject: [PATCH] Fixing memory leak in retrieve_manifests This commit fixes a memory leak with the dir variable. Signed-off-by: Castulo Martinez --- src/manifest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/manifest.c b/src/manifest.c index 18d7a475..18c270f0 100644 --- a/src/manifest.c +++ b/src/manifest.c @@ -447,7 +447,7 @@ static int retrieve_manifests(int current, int version, char *component, struct { char *url = NULL; char *filename; - char *dir; + char *dir = NULL; char *basedir; int ret = 0; struct stat sb; @@ -504,7 +504,6 @@ static int retrieve_manifests(int current, int version, char *component, struct untar: ret = extract_to(filename, dir); - free_string(&dir); if (ret != 0) { goto out; } else { @@ -514,6 +513,7 @@ untar: } out: + free_string(&dir); free_string(&filename); free_string(&url); return ret;