From caa5e2a43ca96faa272bb2c92a177e73aaf83faa Mon Sep 17 00:00:00 2001 From: Otavio Pontes Date: Fri, 16 Nov 2018 18:42:17 +0000 Subject: [PATCH] verifytime: Fix return value of verify_time function There was some confusion about shell return code and bools. Shell returns 0 for true and bools are 0 for false. Signed-off-by: Otavio Pontes --- src/verifytime.c | 6 +++--- src/verifytime_main.c | 6 +++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/verifytime.c b/src/verifytime.c index 1aab6517..188e9cce 100644 --- a/src/verifytime.c +++ b/src/verifytime.c @@ -87,7 +87,7 @@ bool verify_time() versionstamp = get_versionstamp(); if (versionstamp == 0) { - return true; + return false; } time_t versiontime = (time_t)versionstamp; @@ -98,9 +98,9 @@ bool verify_time() * The system time wasn't sane, so set it here and try again */ fprintf(stderr, "Warning: Current time is %s\nAttempting to fix...", asctime(timeinfo)); if (set_time(versiontime) == false) { - return true; + return false; } } - return false; + return true; } diff --git a/src/verifytime_main.c b/src/verifytime_main.c index 2ea3ea89..d03a84df 100644 --- a/src/verifytime_main.c +++ b/src/verifytime_main.c @@ -20,5 +20,9 @@ int main() { - return verify_time() ? 1 : 0; + if (verify_time()) { + return 0; // Success + } + + return 1; // Error }