From 76bacb4556d5cbb35e33d15569b702ba531db9cd Mon Sep 17 00:00:00 2001 From: gprggr Date: Tue, 30 Dec 2014 13:23:59 +0100 Subject: [PATCH] pkg/tar: tar_test.go - fixing possible nil pointer dereference Playing a little with tar.go caused a panic in tar_test.go. This fixes it. --- pkg/tar/tar_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/tar/tar_test.go b/pkg/tar/tar_test.go index 8fff6a9..0999561 100644 --- a/pkg/tar/tar_test.go +++ b/pkg/tar/tar_test.go @@ -207,11 +207,15 @@ func TestExtractTarFolders(t *testing.T) { } dirInfo, err := os.Lstat(filepath.Join(tmpdir, "deep/folder")) - if dirInfo.Mode().Perm() != os.FileMode(0747) { + if err != nil { + t.Errorf("unexpected error: %v", err) + } else if dirInfo.Mode().Perm() != os.FileMode(0747) { t.Errorf("unexpected dir mode: %s", dirInfo.Mode()) } dirInfo, err = os.Lstat(filepath.Join(tmpdir, "deep/deep")) - if dirInfo.Mode().Perm() != os.FileMode(0747) { + if err != nil { + t.Errorf("unexpected error: %v", err) + } else if dirInfo.Mode().Perm() != os.FileMode(0747) { t.Errorf("unexpected dir mode: %s", dirInfo.Mode()) }