mirror of
https://github.com/clearlinux/mixer-tools.git
synced 2026-10-04 15:58:31 +00:00
When checking if the include list has changed between two versions of a manifest, the code was using the return value of compareIncludes() to indicate if a change was present or not. The problem is that this function actually compares the two lists and returns true is they are equal, which is the opposite of the desired check. Regarding the check, when checking if the include list has changed or not, we should only verify if the packages included are still the same, not if their properties have changed. Using DeepEqual() will also check for the properties of the object and will result in false positives when checking for change. This patch renames compareIncludes() to includesChanged() and changes the returned value to match the expected result of this function. It also changes the function implementation to only check the names of the packages instead of all their properties. Signed-off-by: Rodrigo Chiossi <rodrigo.chiossi@intel.com>