From b3cc6a108dc7ac42e7b275a47135c6dbddd3bd7c Mon Sep 17 00:00:00 2001 From: Caio Marcelo de Oliveira Filho Date: Thu, 28 Dec 2017 13:44:17 -0800 Subject: [PATCH] swupd: accept Manifests with "contentsize: 0" Manifest.MoMs currently are produced with "contentsize: 0", e.g. https://download.clearlinux.org/update/20010/Manifest.MoM. Signed-off-by: Caio Marcelo de Oliveira Filho --- swupd/manifest.go | 4 ---- swupd/manifest_test.go | 1 - 2 files changed, 5 deletions(-) diff --git a/swupd/manifest.go b/swupd/manifest.go index fd002f5..9cf5adb 100644 --- a/swupd/manifest.go +++ b/swupd/manifest.go @@ -142,10 +142,6 @@ func (m *Manifest) CheckHeaderIsValid() error { return errors.New("manifest has a zero file count") } - if m.Header.ContentSize == 0 { - return errors.New("manifest has zero contentsize") - } - if m.Header.TimeStamp.IsZero() { return errors.New("manifest timestamp not set") } diff --git a/swupd/manifest_test.go b/swupd/manifest_test.go index 18b9237..d89d931 100644 --- a/swupd/manifest_test.go +++ b/swupd/manifest_test.go @@ -216,7 +216,6 @@ func TestCheckInvalidManifestHeaders(t *testing.T) { {"version zero", ManifestHeader{10, 0, 90, 553, time.Unix(1000, 0), 100000, nil}}, {"no files", ManifestHeader{10, 100, 90, 0, time.Unix(1000, 0), 100000, nil}}, {"no timestamp", ManifestHeader{10, 100, 90, 553, zeroTime, 100000, nil}}, - {"zero contentsize", ManifestHeader{10, 100, 90, 553, time.Unix(1000, 0), 0, nil}}, {"version smaller than previous", ManifestHeader{10, 100, 110, 553, time.Unix(1000, 0), 100000, nil}}, }