From ff42603fdb21fd75af54b58d3b7f448e3ea0319f Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Tue, 6 Sep 2011 02:23:53 +0300 Subject: [PATCH] kvm tools: Attach default 'root=' only if required This patch fixes a case where the 'root=' parameter was passed twice when using virtio-9p root mode. Signed-off-by: Sasha Levin Signed-off-by: Pekka Enberg --- builtin-run.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/builtin-run.c b/builtin-run.c index b9efde2..ef1a358 100644 --- a/builtin-run.c +++ b/builtin-run.c @@ -739,11 +739,10 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix) strlcat(real_cmdline, " init=/bin/sh ", sizeof(real_cmdline)); } - if (!strstr(real_cmdline, "root=")) - strlcat(real_cmdline, " root=/dev/vda rw ", sizeof(real_cmdline)); - if (using_rootfs) - strcat(real_cmdline, " root=/dev/root rootflags=rw,trans=virtio,version=9p2000.L rootfstype=9p"); + strcat(real_cmdline, " root=/dev/root rw rootflags=rw,trans=virtio,version=9p2000.L rootfstype=9p"); + else if (!strstr(real_cmdline, "root=")) + strlcat(real_cmdline, " root=/dev/vda rw ", sizeof(real_cmdline)); if (image_count) { kvm->nr_disks = image_count;