diff --git a/include/kvm/util.h b/include/kvm/util.h index 83088af..2792c88 100644 --- a/include/kvm/util.h +++ b/include/kvm/util.h @@ -9,6 +9,7 @@ * Some bits are stolen from perf tool :) */ +#include #include #include #include @@ -50,7 +51,9 @@ extern void set_die_routine(void (*routine)(const char *err, va_list params) NOR __func__, __LINE__, ##__VA_ARGS__); \ } while (0) -#define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)])) +# +#define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)])) +#define BUG_ON(condition) assert(!(condition)) #define DIE_IF(cnd) \ do { \ diff --git a/ioport.c b/ioport.c index b417942..5a5a331 100644 --- a/ioport.c +++ b/ioport.c @@ -10,7 +10,6 @@ #include #include -#include #include #include #include diff --git a/kvm-cmd.c b/kvm-cmd.c index 604dce4..2520b08 100644 --- a/kvm-cmd.c +++ b/kvm-cmd.c @@ -2,8 +2,6 @@ #include #include -#include - /* user defined header files */ #include "kvm/builtin-debug.h" #include "kvm/builtin-pause.h" @@ -71,14 +69,14 @@ int handle_command(struct cmd_struct *command, int argc, const char **argv) if (!argv || !*argv) { p = kvm_get_command(command, "help"); - assert(p); + BUG_ON(!p); return p->fn(argc, argv, prefix); } p = kvm_get_command(command, argv[0]); if (!p) { p = kvm_get_command(command, "help"); - assert(p); + BUG_ON(!p); p->fn(0, NULL, prefix); return EINVAL; } diff --git a/kvm.c b/kvm.c index 8c9e268..a60b11d 100644 --- a/kvm.c +++ b/kvm.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include diff --git a/pci.c b/pci.c index 06eea0f..41c4085 100644 --- a/pci.c +++ b/pci.c @@ -3,8 +3,6 @@ #include "kvm/util.h" #include "kvm/kvm.h" -#include - #define PCI_BAR_OFFSET(b) (offsetof(struct pci_device_header, bar[b])) static struct pci_device_header *pci_devices[PCI_MAX_DEVICES]; @@ -170,13 +168,13 @@ void pci__config_rd(struct kvm *kvm, union pci_config_address addr, void *data, void pci__register(struct pci_device_header *dev, u8 dev_num) { - assert(dev_num < PCI_MAX_DEVICES); + BUG_ON(dev_num >= PCI_MAX_DEVICES); pci_devices[dev_num] = dev; } struct pci_device_header *pci__find_dev(u8 dev_num) { - assert(dev_num < PCI_MAX_DEVICES); + BUG_ON(dev_num >= PCI_MAX_DEVICES); return pci_devices[dev_num]; } diff --git a/powerpc/kvm.c b/powerpc/kvm.c index f838a8f..d107de6 100644 --- a/powerpc/kvm.c +++ b/powerpc/kvm.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include diff --git a/virtio/console.c b/virtio/console.c index 68c30f5..245cebb 100644 --- a/virtio/console.c +++ b/virtio/console.c @@ -21,7 +21,6 @@ #include #include #include -#include #include #include @@ -136,7 +135,7 @@ static int init_vq(struct kvm *kvm, void *dev, u32 vq, u32 pfn) struct virt_queue *queue; void *p; - assert(vq < VIRTIO_CONSOLE_NUM_QUEUES); + BUG_ON(vq >= VIRTIO_CONSOLE_NUM_QUEUES); compat__remove_message(compat_id); diff --git a/virtio/net.c b/virtio/net.c index bb97a7e..5e29708 100644 --- a/virtio/net.c +++ b/virtio/net.c @@ -19,7 +19,6 @@ #include #include -#include #include #include diff --git a/x86/bios.c b/x86/bios.c index ded0717..0d1b1e3 100644 --- a/x86/bios.c +++ b/x86/bios.c @@ -98,7 +98,7 @@ static void e820_setup(struct kvm *kvm) }; } - BUILD_BUG_ON(i > E820_X_MAX); + BUG_ON(i > E820_X_MAX); e820->nr_map = i; } diff --git a/x86/cpuid.c b/x86/cpuid.c index 644f37f..75f3b4d 100644 --- a/x86/cpuid.c +++ b/x86/cpuid.c @@ -5,7 +5,6 @@ #include #include -#include #define CPUID_FUNC_PERFMON 0x0A diff --git a/x86/kvm.c b/x86/kvm.c index d2fbbe2..129c4ff 100644 --- a/x86/kvm.c +++ b/x86/kvm.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include