From 33348d034d61a17f752f854052cbf843ffb7b146 Mon Sep 17 00:00:00 2001 From: Cyrill Gorcunov Date: Sat, 7 May 2011 19:02:57 +0400 Subject: [PATCH] kvm tools: Fix up PCI pin assignment to conform specification Only 4 pins are allowed for every PCI compilant device as per PCI 2.2 spec Section 2.2.6 ("Interrupt Pins"). Multifunctional devices can use up to all INTA#,B#,C#,D# pins, for our single function devices pin INTA# is enough. Signed-off-by: Cyrill Gorcunov Signed-off-by: Pekka Enberg --- irq.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/irq.c b/irq.c index 4f4305f..15f4702 100644 --- a/irq.c +++ b/irq.c @@ -7,7 +7,6 @@ #include #include -static u8 next_pin = 1; static u8 next_line = 3; static u8 next_dev = 1; static struct rb_root pci_tree = RB_ROOT; @@ -71,7 +70,13 @@ int irq__register_device(u32 dev, u8 *num, u8 *pin, u8 *line) *node = (struct pci_dev) { .id = dev, - .pin = next_pin++, + /* + * PCI supports only INTA#,B#,C#,D# per device. + * A#,B#,C#,D# are allowed for multifunctional + * devices so stick with A# for our single + * function devices. + */ + .pin = 1, }; INIT_LIST_HEAD(&node->lines);