From e781b047ea40cf5e9b2dcb875ef1947d640ffb0a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kowalczyk?= <mkow@users.noreply.github.com>
Date: Tue, 5 Dec 2017 17:33:45 +0100
Subject: [PATCH] Various allocator bugfixes (#128)

* Fix off-by-one in test_vma_overlap()

* Fix calloc crash when underlying malloc fails

* Use `bool` where possible

* Fix C-string null-termination in __set_comment
---
 LibOS/shim/src/bookkeep/shim_vma.c | 22 +++++++++++-----------
 LibOS/shim/src/shim_malloc.c       |  3 ++-
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/LibOS/shim/src/bookkeep/shim_vma.c b/LibOS/shim/src/bookkeep/shim_vma.c
index 5fcd2a12..c63fefcf 100644
--- a/LibOS/shim/src/bookkeep/shim_vma.c
+++ b/LibOS/shim/src/bookkeep/shim_vma.c
@@ -77,40 +77,39 @@ DEFINE_LISTP(shim_vma);
 static LISTP_TYPE(shim_vma) vma_list = LISTP_INIT;
 static LOCKTYPE vma_list_lock;
 
-static inline int test_vma_equal (struct shim_vma * tmp,
+static inline bool test_vma_equal (struct shim_vma * tmp,
                                   const void * addr, uint64_t length)
 {
-    return tmp->addr == addr &&
-           tmp->addr + tmp->length == addr + length;
+    return tmp->addr == addr && tmp->length == length;
 }
 
-static inline int test_vma_contain (struct shim_vma * tmp,
+static inline bool test_vma_contain (struct shim_vma * tmp,
                                     const void * addr, uint64_t length)
 {
     return tmp->addr <= addr &&
            tmp->addr + tmp->length >= addr + length;
 }
 
-static inline int test_vma_startin (struct shim_vma * tmp,
+static inline bool test_vma_startin (struct shim_vma * tmp,
                                     const void * addr, uint64_t length)
 {
     return tmp->addr >= addr &&
            tmp->addr < addr + length;
 }
 
-static inline int test_vma_endin (struct shim_vma * tmp,
+static inline bool test_vma_endin (struct shim_vma * tmp,
                                   const void * addr, uint64_t length)
 {
     return tmp->addr + tmp->length > addr &&
            tmp->addr + tmp->length <= addr + length;
 }
 
-static inline int test_vma_overlap (struct shim_vma * tmp,
+static inline bool test_vma_overlap (struct shim_vma * tmp,
                                     const void * addr, uint64_t length)
 {
-    return test_vma_contain (tmp, addr + 1, 0) ||
-           test_vma_contain (tmp, addr + length - 1, 0) ||
-           test_vma_startin (tmp, addr, length - 1);
+    return test_vma_contain(tmp, addr, 1) ||
+           test_vma_contain(tmp, addr + length - 1, 1) ||
+           test_vma_startin(tmp, addr, length);
 }
 
 int bkeep_shim_heap (void);
@@ -274,7 +273,8 @@ static inline void __set_comment (struct shim_vma * vma, const char * comment)
     if (len > VMA_COMMENT_LEN - 1)
         len = VMA_COMMENT_LEN - 1;
 
-    memcpy(vma->comment, comment, len + 1);
+    memcpy(vma->comment, comment, len);
+    vma->comment[len] = 0;
 }
 
 static int __bkeep_mmap (void * addr, uint64_t length,
diff --git a/LibOS/shim/src/shim_malloc.c b/LibOS/shim/src/shim_malloc.c
index 6a3638cd..0c341d55 100644
--- a/LibOS/shim/src/shim_malloc.c
+++ b/LibOS/shim/src/shim_malloc.c
@@ -330,7 +330,8 @@ void * calloc (size_t nmemb, size_t size)
 {
     size_t total = nmemb * size;
     void *ptr = malloc(total);
-    memset(ptr, 0, total);
+    if (ptr)
+        memset(ptr, 0, total);
     return ptr;
 }
 extern_alias(calloc);