Jessica Frazelle
debf60b466
Merge branch master into bump_v1.4.0
...
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com > (github: jfrazelle)
2014-12-11 15:00:03 -08:00
unclejack
bff1d9dbce
validate image ID properly & before load
...
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com >
Conflicts:
graph/load.go
2014-12-11 16:29:27 -05:00
Michael Crosby
9a7a1e5be0
Refactor put image function's redirect loop
...
Signed-off-by: Michael Crosby <crosbymichael@gmail.com >
2014-12-10 18:11:27 -08:00
Michael Crosby
3b4de1070f
Prevent loop with var overshadowing
...
Incase of a 3xx redirect the var was being overshowed and ever changed
causing an infinite loop.
Fixes #9480
Signed-off-by: Michael Crosby <crosbymichael@gmail.com >
2014-12-10 17:43:21 -08:00
unclejack
acf1720b3f
validate image ID properly & before load
...
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com >
2014-12-09 14:56:16 -05:00
Vaidas Jablonskis
d96832cbd2
registry: fix ServerAddress setting
...
This ensures that ServerAddress is set, while previously it was getting
set after configFile.Configs.
Signed-off-by: Vaidas Jablonskis <jablonskis@gmail.com >
2014-11-24 18:26:41 +00:00
Tibor Vass
5e2d02ab73
Add the possibility of specifying a subnet for --insecure-registry
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Conflicts:
registry/endpoint.go
2014-11-14 14:20:19 -08:00
Tibor Vass
eb3738347a
registry: parse INDEXSERVERADDRESS into a URL for easier check in isSecure
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-11-14 14:20:19 -08:00
Tibor Vass
6152460c1e
Put mock registry address in insecureRegistries for unit tests
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Conflicts:
registry/registry_mock_test.go
2014-11-14 14:20:19 -08:00
Tibor Vass
1527979e87
registry: refactor registry.IsSecure calls into registry.NewEndpoint
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Conflicts:
registry/endpoint.go
registry/endpoint_test.go
registry/registry_test.go
2014-11-14 14:05:31 -08:00
Tibor Vass
6aba75db4e
Add the possibility of specifying a subnet for --insecure-registry
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-11-14 12:31:11 -08:00
Tibor Vass
fbe10c83d8
registry: parse INDEXSERVERADDRESS into a URL for easier check in isSecure
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-11-13 07:02:24 -08:00
Tibor Vass
78e859f3c3
Put mock registry address in insecureRegistries for unit tests
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-11-12 20:34:03 -06:00
Tibor Vass
4455f51760
registry: refactor registry.IsSecure calls into registry.NewEndpoint
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-11-12 20:34:03 -06:00
Erik Hollensbe
11380a109e
registry: always treat 127.0.0.1 as insecure for all cases anytime anywhere
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-11-12 12:14:43 -08:00
Johan Euphrosine
28ee373e19
registry: default --insecure-registry to localhost and 127.0.0.1
...
Signed-off-by: Johan Euphrosine <proppy@google.com >
2014-11-12 09:12:42 -08:00
Tibor Vass
e08d1f6af2
Merge pull request #9095 from proppy/is-secure-test
...
registry: add tests for IsSecure
2014-11-11 16:52:36 -05:00
Johan Euphrosine
75e3b35bf1
registry: add tests for IsSecure
...
Signed-off-by: Johan Euphrosine <proppy@google.com >
2014-11-11 11:02:32 -08:00
Vincent Batts
a368e064a9
registry: don't iterate through certs
...
the golang tls.Conn does a fine job of that.
http://golang.org/src/pkg/crypto/tls/handshake_client.go?#L334
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-11-04 16:12:23 -05:00
Tibor Vass
05c18a2434
Fix login command
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-10-30 19:44:44 -04:00
Tibor Vass
6a1ff022b0
Do not verify certificate when using --insecure-registry on an HTTPS registry
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Conflicts:
registry/registry.go
registry/registry_test.go
registry/service.go
registry/session.go
Conflicts:
registry/endpoint.go
registry/registry.go
2014-10-30 19:44:09 -04:00
Michael Crosby
afade4236d
Don't hard code true for auth job
...
Signed-off-by: Michael Crosby <michael@docker.com >
Conflicts:
registry/service.go
2014-10-30 19:41:55 -04:00
Michael Crosby
f29b2e48eb
Refactor IsSecure change
...
Fix issue with restoring the tag store and setting static configuration
from the daemon. i.e. the field on the TagStore struct must be made
internal or the json.Unmarshal in restore will overwrite the insecure
registries to be an empty struct.
Signed-off-by: Michael Crosby <michael@docker.com >
Conflicts:
graph/pull.go
graph/push.go
graph/tags.go
2014-10-30 19:41:55 -04:00
unclejack
380c8320a7
make http usage for registry explicit
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
Conflicts:
daemon/config.go
daemon/daemon.go
graph/pull.go
graph/push.go
graph/tags.go
registry/registry.go
registry/service.go
2014-10-30 19:41:55 -04:00
Tibor Vass
e6efbd6596
Fix login command
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-10-30 09:17:11 -04:00
Victor Vieux
265a89a605
Merge pull request #8387 from vbatts/vbatts-registry_test_enpoint
...
registry/endpoint: make it testable
2014-10-29 13:36:17 -07:00
Jessie Frazelle
565340c90c
Merge pull request #8669 from monsterzz/8668-dualstack-registry
...
Use dual-stack Dialer when talking to registy
2014-10-29 12:03:12 -07:00
Jessica Frazelle
35703d4f0c
Fix error on successful login.
...
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com > (github: jfrazelle)
2014-10-28 17:42:03 -07:00
Igor Dolzhikov
b65eb8d215
excluding unused transformation to []byte
...
Signed-off-by: Igor Dolzhikov <bluesriverz@gmail.com >
2014-10-28 01:04:36 +06:00
Alexandr Morozov
ee7dd44c01
Mass gofmt
...
Signed-off-by: Alexandr Morozov <lk4d4@docker.com >
2014-10-24 15:11:48 -07:00
Alexandr Morozov
7c62cee51e
Use logrus everywhere for logging
...
Fixed #8761
Signed-off-by: Alexandr Morozov <lk4d4@docker.com >
2014-10-24 15:03:06 -07:00
Vincent Batts
3eba719400
registry/endpoint: make it testable
...
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-10-24 16:27:17 -04:00
Tibor Vass
9df3e45ba9
Merge pull request #8423 from unclejack/lint_changes
...
lint changes part 1
2014-10-21 12:15:58 -04:00
Gleb M Borisov
fdd2abe7b3
Use dual-stack Dialer when talking to registy
...
Signed-off-by: Gleb M. Borisov <borisov.gleb@gmail.com >
2014-10-21 03:59:11 +04:00
Daniel, Dao Quang Minh
8caacb18f8
Avoid fallback to SSL protocols < TLS1.0
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <dqminh89@gmail.com > (github: dqminh)
Conflicts:
registry/registry.go
2014-10-20 16:51:06 -04:00
Tibor Vass
e134f1f74a
Do not verify certificate when using --insecure-registry on an HTTPS registry
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Conflicts:
registry/registry.go
registry/registry_test.go
registry/service.go
registry/session.go
2014-10-20 16:51:06 -04:00
Michael Crosby
f43e77fc12
Don't hard code true for auth job
...
Signed-off-by: Michael Crosby <michael@docker.com >
Conflicts:
registry/service.go
2014-10-20 16:51:05 -04:00
Michael Crosby
c0598aced0
Refactor IsSecure change
...
Fix issue with restoring the tag store and setting static configuration
from the daemon. i.e. the field on the TagStore struct must be made
internal or the json.Unmarshal in restore will overwrite the insecure
registries to be an empty struct.
Signed-off-by: Michael Crosby <michael@docker.com >
Conflicts:
graph/pull.go
graph/push.go
graph/tags.go
2014-10-20 16:51:05 -04:00
unclejack
f9b4bfa59b
make http usage for registry explicit
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
Conflicts:
daemon/config.go
daemon/daemon.go
graph/pull.go
graph/push.go
graph/tags.go
registry/registry.go
registry/service.go
2014-10-20 16:51:05 -04:00
Dan Walsh
69fe3e1a34
On Red Hat Registry Servers we return 404 on certification errors.
...
We do this to prevent leakage of information, we don't want people
to be able to probe for existing content.
According to RFC 2616, "This status code (404) is commonly used when the server does not
wish to reveal exactly why the request has been refused, or when no other response i
is applicable."
https://www.ietf.org/rfc/rfc2616.txt
10.4.4 403 Forbidden
The server understood the request, but is refusing to fulfill it.
Authorization will not help and the request SHOULD NOT be repeated.
If the request method was not HEAD and the server wishes to make
public why the request has not been fulfilled, it SHOULD describe the
reason for the refusal in the entity. If the server does not wish to
make this information available to the client, the status code 404
(Not Found) can be used instead.
10.4.5 404 Not Found
The server has not found anything matching the Request-URI. No
indication is given of whether the condition is temporary or
permanent. The 410 (Gone) status code SHOULD be used if the server
knows, through some internally configurable mechanism, that an old
resource is permanently unavailable and has no forwarding address.
This status code is commonly used when the server does not wish to
reveal exactly why the request has been refused, or when no other
response is applicable.
When docker is running through its certificates, it should continue
trying with a new certificate even if it gets back a 404 error code.
Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com > (github: rhatdan)
2014-10-20 13:20:48 -04:00
Daniel, Dao Quang Minh
7a062b2b8f
Avoid fallback to SSL protocols < TLS1.0
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <dqminh89@gmail.com > (github: dqminh)
2014-10-15 22:39:51 -04:00
Derek McGowan
73a9089306
Support tarsum dev version to fix issue with mtime
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net > (github: dmcgowan)
2014-10-10 16:04:29 -07:00
Derek McGowan
15d5c7f10f
Update manifest format to rename blobsums and use arrays of dictionaries
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net > (github: dmcgowan)
2014-10-10 16:04:29 -07:00
Derek McGowan
a152f37674
Use direct registry url
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net > (github: dmcgowan)
2014-10-10 16:04:28 -07:00
unclejack
ae3b59c171
registry: lint
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-10-06 22:34:39 +03:00
Derek McGowan
22e59009e4
Add comment for permission and fix wrong format variable
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net > (github: dmcgowan)
2014-10-02 17:41:57 -07:00
Derek McGowan
7c88e8f13d
Add provenance pull flow for official images
...
Add support for pulling signed images from a version 2 registry.
Only official images within the library namespace will be pull from the
new registry and check the build signature.
Signed-off-by: Derek McGowan <derek@mcgstyle.net > (github: dmcgowan)
2014-10-01 18:26:06 -07:00
Vincent Batts
61c6f206b0
registry: getting Endpoint ironned out
...
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-10-01 13:19:40 -07:00
Tibor Vass
808257654a
Replace get.docker.io -> get.docker.com and test.docker.io -> test.docker.com
...
Signed-off-by: Tibor Vass <teabee89@gmail.com >
2014-09-24 18:53:27 -04:00
Phil Estes
4119c9d7d9
Refactor all pre-compiled regexp to package level vars
...
Addresses #8057
Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com >
2014-09-16 12:57:44 -04:00